WPDR will support Featured Image

  • Resolved nwjames

    (@nwjames)


    6 years, 3 months ago

    Thank you for upgrading your plugin.

    Since I had been doing some work on WPDR, I installed your plugin and took a look.

    I recently made a fix to allow WPDR to support Featured Images – and this is in the version on Ben Balter’s github repository, so I expect it will be released at some time.

    Since the Featured Image metabox disappeared, I looked for why.

    Your code filters “supports” – and uses a default set of values. That’s OK for the current release version as the default set is that of WPDR.

    Would it be possible sometime to change the code to 

    $args[ 'supports' ] = apply_filters(
			'wpdrsd_filter_post_type_supports',
			$args[ 'supports' ]
);

    Unless, of course, you do not want Featured Images to be supported.

    Can I point out a couple of things of ddw_wpdrsd_post_type_as_downloads function for your consideration please:

    1. It filters on register_post_type_args – and needs to test for the post type.

    It could filter on the existing WPDR filter document_revisions_cpt and then only be invoked for the document post type.

    2. It tests for the option wpdrsd_downloads_labels. If not there, it returns without a value.

    It should return $args

    Hope this is of use.

    Regards,
    Neil James

Viewing 1 replies (of 1 total)
  • Plugin Author David Decker

    (@daveshine)

    @nwjames

    Hi James!

    Thank you for your great feedback and the corrections.
    I just pushed version 1.2.1 few minutes ago which implements all your suggestions.
    Only for the function and filter I kept it for now – it already has the post type check included since v1.2.0, in this line:
    if ( 'document' === $post_type ) {

    I can see no issue with that – if there might be an oversight from me, we can switch to the WPDR filter also.

    Tested with WPDR master from GitHub and all featured images are now there – meta box all there ??

    I like featured image support a lot – makes total sense! Would love if Ben would release this very soon. Since I see you with lot of commits over there you hopefully get added as contributor and we see more releases, hopefully! ??

    Thanks again for your great support, really appreciate it!
    –Dave ??

Viewing 1 replies (of 1 total)
  • The topic ‘WPDR will support Featured Image’ is closed to new replies.