WP 5.1 Support?
-
After upgrade to WP 5.1 , I can no longer use HTML in tables.
The tables break immediately. Syntax error https://tablepress.org/faq/corrupted-tables/The problem is definitely not in the plugins. I didn’t have any new plugins. I tried to disable all recently updated – did not help.
-
Yep, I have just upgraded to WP5.1 and have the same error. It’s a massive table too.
I have this error too. Please, upgrade the plugin.
Happy with your posts guys, i feel much less alone with my problem now… ?? hope we get help, all best Martin
Same here. It happened just after I had upgraded to WP5.1 and to Table Press 1.9. Impossible to update tables and to reimport them with the same syntax as previously.
Tables are corrupt and won’t diplay.I have removed the WP 5.1 update as a temp fix – definitely the update, not a plugin issue.
Thanks
Hi,
thanks for your post, and sorry for the trouble.
I have received a few reports about this and I’m currently looking into the problem! I hope to find a cause and a solution as soon as possible!
In the meantime, please try avoiding to edit tables, and just for extra caution, please create a backup of all tables by exporting them to the JSON format in a ZIP archive. In addition, please also create a full database backup, e.g. with phpMyAdmin or similar tools.Regards,
TobiasI can’t export tables now because of “table is damaged”.
Me too.
I now have a problem with several websites that are using the plugin and, most important of all, in one case I have to update a table every week.
Hi everybody,
here’s a first update: I have traced this back to a recent change in the WordPress code, that is related to HTML code for links (
<a href="...
) that use thetarget="_blank"
attribute to open the link in a new browser window/tab.
As this can have security implications, WordPress added a code change that aims at making these safer, by also adding arel="noopener noreferrer"
attribute.
However, the method of how this extra attribute is added is currently not compatible with the internal JSON data format of TablePress and therefore corrupts it.I have created a bug ticket for WordPress, at https://core.trac.www.ads-software.com/ticket/46316
I’m currently thinking about a possible temporary fix in TablePress, but ultimately, this will most likely have to be fixed in the WordPress code.
To summarize: From what I can see so far, your tables are only at risk of corruption, if they contain a HTML link with a
target
attribute, i.e. something like<a href="..." target="_blank">link</a>
Tables without such a link can be edited safely, it appears.
Also, I’m pretty sure that none of your tables will be lost. We’ll just have to fix some invalid JSON syntax in the database. I’ll try to come up with clear instructions, once the original issue has been fixed, as a priority right now is to prevent other users from also observing this problem.
If you feel experienced (AND have a database backup!), you could try fixing the JSON code manually in thewp_posts
database table (in entries with a value oftablepress_table
in thepost_type
column), with a tool like phpMyAdmin.Regards,
TobiasHi,
I was about to come here to tell you where the problem is but looks like you figured it out already! I was able to uncorrupt my table data by grabbing the JSON-data from phpMyAdmin and running a search-replace on the quotation marks to change them from
” to \”
and then importing the data to Tablepress from WP Admin panel. I had to revert back to WP 5.0.3 and I’m running Tablepress 1.9.1
I’m waiting on an update to WP to fix this before I upgrade WP core.
Thanks Tobias, removing the target attribute appears to work as a temporary fix while you carry on “scratching your head”.
So, if I too stupid to edit data tables manually, I need just wait for the plugin update?
Hi,
here’s a second update:
To prevent this from happening again, on further tables, or on tables that you were already able to restore manually, you can make a temporary code change to TablePress:
Under “Plugins” -> “Plugin Editor” in your admin dashboard, choose “TablePress”. This should let you edit the file “/wp-content/plugins/tablepress/tablepress.php” (you could therefore also do this via FTP, if you prefer).
There, scroll down all the way, and find the lineadd_action( 'init', array( 'TablePress', 'run' ) );
Below that line, add the new line
add_action( 'init', 'wp_remove_targeted_link_rel_filters' );
and click “Update File”.
This change will turn off the filter hook functions that cause the corrupted tables for now. After that, no further tables should get corrupted.
However, this will not directly restore previously corrupted tables! I” currently looking into possible options to make restoring corrupted tables as easy as possible and will post an update here again.
Regards,
Tobias- This reply was modified 5 years, 9 months ago by TobiasBg.
Same problem here after update. Weekend is extremely important for my site so bad timing it had to happen now. Tobias is an awesome guy, however, and I feel confident that he is doing his best for us.
I noticed that a few of you solved it by reverting back to the last version. How do you do that? Is there an easy way?
- This reply was modified 5 years, 9 months ago by danniee.
Hi,
reverting back to a previous version of WordPress or TablePress will not help in any way (as this will not restore any corrupted tables).
If you are affected by corrupted tables after updating to WordPress 5.1 and editing tables, it’s the best to stay on that version but maybe apply the recommended code change from my previous reply here (or wait a few more minutes until I have released TablePress 1.9.2 with a temporary fix).
After that, I’ll go into details on how to restore corrupted tables.
Regards,
Tobias
- The topic ‘WP 5.1 Support?’ is closed to new replies.