Obsolete CSS rules

  • Resolved kubiq

    (@kubiq)


    5 years, 6 months ago

    Hello,

    thank you for a great plugin ??

    Please remove this CSS rule from /coblocks/dist/blocks.style.build.css

    .wp-block-coblocks-column p, .wp-block-coblocks-column a, .wp-block-coblocks-column h1, .wp-block-coblocks-column h2, .wp-block-coblocks-column h3, .wp-block-coblocks-column h4, .wp-block-coblocks-column h5, .wp-block-coblocks-column h6 {
    color: inherit;
    }

    What is it good for?

    I have styles in my theme for h1,h2,h3 defined and it will overwrite color.
    So then I have to duplicate selectors and use also these classes (.wp-block-coblocks-column) before each. Second possibility is to use !important but that’s bad practice.

    Let me know if there is some reason that I don’t see, but I think it can be removed ??

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Rich Tabor

    (@richtabor)

    Hi @kubiq, we’re reviewing this in this pull request. It’s definitely a bit tricky, but I have a few ideas how we’ll resolve this.

    Thanks for the report!

    Plugin Author Rich Tabor

    (@richtabor)

    Good news @kubiq! Took some time to thoughtfully test and ensure we have the appropriate fallbacks in place, but we’ve removed this in the latest release that went out yesterday – as well as added a new collage block, lightbox capability, and a new thumbnails option to the carousel block.. AND a load of tweaks, fixes and improvements all around. Let me know what you think!

    Thread Starter kubiq

    (@kubiq)

    Great work! Thank you very much ??

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Obsolete CSS rules’ is closed to new replies.