Viewing 13 replies - 1 through 13 (of 13 total)
  • Plugin Author WebFactory

    (@webfactory)

    Hi, there’s no reason for it to do that! And it shouldn’t be doing it. We’ll look into it and fix the issue in the next version. Thank you for letting us know.

    Thread Starter politicske

    (@politicske)

    You are welcome.

    Thread Starter politicske

    (@politicske)

    @webfactory 1. would you kindly clarify on which pages this plugin should be loading its CSS in the admin page? 2. I am having to deregister the font awesome script inside your plugin with every update. Would you set it to load only if font awesome is chosen from the dropdown in settings?

    Thank you.

    Plugin Author WebFactory

    (@webfactory)

    Hi,
    We’re releasing an update no later than tomorrow that will fix this issue. Our CSS should only be loaded on the WPEL settings page and nowhere else. We’ll also make sure FA only loads if needed.

    Thread Starter politicske

    (@politicske)

    This CSS is still loading globally. Should it? Also, GTmetrix detected font awesome loading on the front end and I had to deregister it again after updating.

    font-face {
        font-family: 'external-links';
        src: url('font/external-links.eot?25257834');
        src: url('font/external-links.eot?25257834#iefix') format('embedded-opentype'),
             url('font/external-links.woff2?25257834') format('woff2'),
             url('font/external-links.woff?25257834') format('woff'),
             url('font/external-links.ttf?25257834') format('truetype'),
             url('font/external-links.svg?25257834#external-links') format('svg');
        font-weight: normal;
        font-style: normal;
      }
    
    a.toplevel_page_wpel-settings-page .wp-menu-image:before,
    a.toplevel_page_wpel-network-settings-page .wp-menu-image:before{
        font-family: "external-links";
        font-style: normal;
        font-weight: normal;
        speak: none;
        display: inline-block;
        text-decoration: inherit;
        width: 1em;
        margin-right: .2em;
        text-align: center;
        font-variant: normal;
        text-transform: none;
        line-height: 1em;
        margin-left: .2em;
        -webkit-font-smoothing: antialiased;
        -moz-osx-font-smoothing: grayscale;
        content: '\f14c';
      }
    Plugin Author Alexandru Tapuleasa

    (@talextech)

    Hi,

    Yes, there is still a little bit of CSS that is loaded globally for the plugin’s Menu icon ?? But all other CSS and FontAwesome are no longer loaded globally.

    On the frontend, FontAwesome will only be loaded if you selected to use Font Awesome as an icon for links.

    Thread Starter politicske

    (@politicske)

    The FA icons CDN is loading even when not selected https://prntscr.com/pzvj9x. All my settings are ‘no icons’. I don’t use font awesome across my site and prefer SVG instead and this CDN link adds an extra request to my load time.

    Plugin Author Alexandru Tapuleasa

    (@talextech)

    Hi,

    That would be a bug, yes, but we can’t reproduce it ??
    Can you send copy/paste the Technical info in the External Links Settings page Support tab? Also, can you give us a link to a page where FontAwesome is loaded by External Links?

    Thread Starter politicske

    (@politicske)

    1. So I assume the global CSS loads only when the plugin is set to have its own admin menu? What if it is inside the settings section? Can that CSS be limited to load only when the separate admin section is activated?
    2. I have narrowed down the problem of the plugin’s FA loading when used alongside the GeneratePress theme. It did not load when I used the 2020 theme. Does that help in troubleshooting?

    Plugin Author Alexandru Tapuleasa

    (@talextech)

    Hi,

    1.No, the global CSS cannot be set to load only on the plugin’s page as it’s required for the menu icon. It does not affect absolutely anything other than that menu icon. Any additional CSS that the plugin needs is loaded only on the plugin’s page.

    2.The fact that it’s not loading FontAwesome in the frontend with all themes kind of demonstrates that it’s not WPEL that is the issue. But I have tested it with GeneratePress and do not see FontAwesome loaded even with that ( https://prnt.sc/q02g2g )

    So I assume it’s something else or a combination of things that is causing the issue but without being able to reproduce it there is not much we can do ??

    Thread Starter politicske

    (@politicske)

    1. Okay.
    2. I had to enable this option in the theme for the request to disappear https://prntscr.com/q033es. It seems the theme’s function to call the CDN was conflicting with your plugin’s. Consider this resolved.

    Plugin Author WebFactory

    (@webfactory)

    Glad to hear it’s resolved ??

    If you have a minute please rate the plugin. It’s what keeps the support going – https://www.ads-software.com/support/plugin/wp-external-links/reviews/#new-post

    Thread Starter politicske

    (@politicske)

    Will do. I also support the recommendation to introduce a way to have the plugin clean after itself in the database if deleted. It is a good thing for troubleshooting errors.

Viewing 13 replies - 1 through 13 (of 13 total)
  • The topic ‘CSS’ is closed to new replies.