Markup validation

  • Resolved tictok

    (@tictok)


    5 years ago

    Hi – thanks for your plugin, works really well and I personally think helps UX considerably.

    I know that validation (W3C) isn’t everything, but pretty much the only bit of my site that doesn’t validate is the quantity buttons generated by ‘SMNTCS WooCommerce Quantity Buttons’.

    3 errors:
    – Attribute ‘size’ not allowed on element input
    – Attribute ‘pattern’ is only allowed when the input type is email, password, search, tel, text, or url
    – The value of the for attribute of the label element must be the ID of a non-hidden form control. (this is for the screen reader text on the <label> element)

    1 warning:
    – The ‘inputmode’ attribute is not supported in all browsers

    It’d be fantastic if this could be addressed for a future update.

    Many thanks

    // EDIT:
    Just spotted that the quantity field mark-up in your pluginis similar to that generated by the default quantity-input.php template in WooCommerce – they both produce the validation errors. Appologies as it seems your plugin is not the root of the cause, but it would still great if could be fixed! Many thanks

    • This topic was modified 5 years ago by tictok.
Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Niels Lange

    (@nielslange)

    @tictok Sorry for my late reply. Yesterday, I validated the markup and a few minutes ago, I published a new release. I’ve only addressed the errors though, not the warning. Let me know if the errors are gone on your end now.

    Thread Starter tictok

    (@tictok)

    That’s brilliant – all good here.
    Thank you for taking the time ??

    Plugin Author Niels Lange

    (@nielslange)

    @tictok Thank you for pointing out this issue in the first place! ??

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Markup validation’ is closed to new replies.