Problem with Elementor and Fast Velocity Minify

  • Resolved dulesaga

    (@dulesaga)


    4 years, 9 months ago

    Hello,

    I have some issues with getting all pages built with Elementor to work with the Fast Velocity Minify plugin, he problem seems to be that in the plugin codebase you are using hash(‘adler32’ hash function which is not intended for that particular use, and is causing collisions and trying to load the wrong header-… css file.

    Can you look into pushing a fix, for now, I think I’ve resolved the issue by replacing all instances hash(‘adler32 to hash(‘md5 – it looks a bit ugly but it works.

    Thanks

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Raul P.

    (@alignak)

    Hi,

    Thank you for your message.
    That situation is indeed interesting.

    I am aware that adler32 is not for hashes but more for error detection after decompression and other similar usage, however I just needed something small and fast and that one was a good candidate.

    I wouldn’t expect collisions to happen under normal usage, but I can imagine it may happen if we use small strings. This is however, the first time I’ve seen it, so thank you for posting.

    I’ll probably use sha1 or sha256 later, though it’s a bit ugly like you said.
    Or I may think of something else… will see.

    Thanks again

    Thread Starter dulesaga

    (@dulesaga)

    Hi,

    Maybe you can add some kind of a salt string to the hash if that is what’s making it weak for smaller strings.

    In my case for some reason every ~ 10th page had a collision, note sure why, here’s a post I found on stackoveflow

    https://stackoverflow.com/questions/13455067/horrific-collisions-of-adler32-hash

    Hi,

    I also had the collision problem with Elementor + FVM. Changing hashing algorithm to md5 fixed it for now.

    Plugin Author Raul P.

    (@alignak)

    This was updated on the latest version. Thanks for reporting.

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Problem with Elementor and Fast Velocity Minify’ is closed to new replies.

Tags