• Resolved vemman

    (@vemman)


    Nice plugin. Found a small stuff to nag on

    Please check line 87 ./public/class-wp-tabs-shortcode.php

    $title_data_attr = 'aria-controls="<?php echo esc_attr( $tabs_aria_controls_for_id ); ?>" aria-selected="false"';

    $tabs_aria_controls_for_id is not defined at 87, changed it to
    $title_data_attr = 'aria-controls="%s" aria-selected="false"';

    and used as following on line 121:
    echo sprintf($title_data_attr, $tabs_aria_controls_for_id);

    • This topic was modified 4 years, 8 months ago by vemman. Reason: more details added
Viewing 1 replies (of 1 total)
  • Plugin Author ShapedPlugin LLC

    (@shapedplugin)

    Hi,

    Thank you so much for pointing out the codes. We have noted your comment and we’ll try to add this fix to the next update.

    Thanks again for helping us to improve the plugin.
    The ShapedPlugin Team

Viewing 1 replies (of 1 total)
  • The topic ‘A minor issue in class-wp-tabs-shortcode.php’ is closed to new replies.