French translation

Hi @css31

That’s awesome. I’ve tagged a stable branch (1.3.2) just now.

Bon appetit.

Hi Michael,

Thanks a lot. It works.

Nevertheless translations files seems to have a wrong name.

After the update they appear in /wp-content/languages/plugins/ with the name :

• log-cleaner-for-ithemes-security-fr_FR.po
• log-cleaner-for-ithemes-security-fr_FR.mo

But the translation is not applied.

Changing name with

• log-cleaner-fr_FR.po
• log-cleaner-fr_FR.mo

make it works.

Could you correct it?

One of my colleague told me that it was a text domain issue, as you can see here
https://wp-info.org/tools/checkplugini18n.php?slug=log-cleaner-for-ithemes-security

Best,

• This reply was modified 4 years, 6 months ago by Cyrille Sanson.

Hi Cyrille,

I embarrassed to admit I had no idea the text domain had to match the plugin slug, or that it isn’t even required to be specified in the header since 4.6 (if it’s the same as the plugin slug).

Anyhoo, I’ve pushed a new version with the updated text domain to match the plugin slug, and FYI stable is now 1.3.3.

Let me know if that’s all good now.

Hi Michael,

Thanks. It’s almost perfect.

Now translation are updated and used by the plugin.

There is a weird effect. The translation of the following sentence is not taken into account:

Note: Continuing here will delete the selected iThemes Security logs from the database….

Thanks,

• This reply was modified 4 years, 6 months ago by Cyrille Sanson.

My bad. I missed that one. All appears to be good now.

Apologies for all the back-and-forth.

Hi Michael,

Sorry I don’t see the fix.

Are you going to publish a new version?

Thanks,

Yes absolutely.

I didn’t see any point in adding a new version number though, so it’s still part of 1.3.3.

You can see the change done 24hrs ago here: https://plugins.trac.www.ads-software.com/changeset/2298873/

Hi Michael,

To apply the change, it is therefore necessary to uninstall / reinstall the plugin.

It would have been easier if it would have been possible to change the version.

Anyway, thank you very much,

No worries.

What now? I expected to pull the repo and see the new translation files in stable, but that wasn’t the case. Or do I need to approve it somehow first? I couldn’t find any answer to these questions.

Cheers.