• Resolved a223123131

    (@a223123131)


    With 2.1.4 and 2.1.5 the layout is broken. In the screen you see the part behind 1) which shouldn’t be there. The same is in the reference container.

    When I change the footnote the changes will be added, not replaced… means the wrong part after 1) get’s longer and longer with each change of the footnote.

    https://dlgo.de/footnotes.jpg

    I’m running now on 2.1.3 where everything is working.

Viewing 14 replies - 1 through 14 (of 14 total)
  • Thread Starter a223123131

    (@a223123131)

    I tryed the different options of “Apply basic responsive page layout:” with no success.

    Plugin Contributor pewgeuges

    (@pewgeuges)

    @a223123131

    I can’t seem to get this regex right. It works on other websites; I still don’t understand what I’m missing. Thanks for your screenshot, that shows a truncated hyperlink. The regex only catches URLs that are not the value of an href or src argument, start with http and end before the first occurrence of either space or less-than angle bracket. This measure was indispensable because of Unicode non conformant browsers not breaking URLs at slashes, and expanding tables into the margin instead, or having URLs hang out of the tooltip. FTP protocols are not caught, though.

    The page layout fix is mainly for situations where the reference container does not benefit from common style rules as applied to content. Until now, the only use case I know is Hello theme using the associated page builder. It is not needed if either is missing, hence “Most themes don’t need this fix.”

    May you please copy-paste the code of the footnote in your next reply, or share the page’s URL so I have a chance to check and try to understand, please?

    Thank you.

    Plugin Contributor pewgeuges

    (@pewgeuges)

    @a223123131

    A development version with a new option to disable URL wrap is now available at https://downloads.www.ads-software.com/plugin/footnotes.zip
    Would you like to give it a try? If so, please disable URL wrap in the dashboard Settings tab > Other settings > Allow URLs to line-wrap anywhere: -> No. This will disable adding the span around URLs to allow line breaks anywhere.

    If that fixes the issue, then the regex is wrong. If not, things are even worse.

    Thank you in advance.

    Thread Starter a223123131

    (@a223123131)

    I have enabled the latest official version that you can seee the issue. Also I updated the footnote several times.

    Can I send you the URL by mail?

    • This reply was modified 3 years, 11 months ago by a223123131.
    • This reply was modified 3 years, 11 months ago by a223123131.
    Thread Starter a223123131

    (@a223123131)

    Same issue with your developer version

    Thread Starter a223123131

    (@a223123131)

    The hyperlink is setup with this in Gutenberg

    [[https://google.de]]

    I use the double edge blackets for start end end shortcode. The text between this shortcodes I have activated as a hyperlink.

    • This reply was modified 3 years, 11 months ago by a223123131.
    • This reply was modified 3 years, 11 months ago by a223123131.
    Thread Starter a223123131

    (@a223123131)

    Ok, here’s the exctract of the source code from the ‘123 [[https://google.de]]’ test link: https://dlgo.de/footnote.php (right click to download)

    • This reply was modified 3 years, 11 months ago by a223123131.
    Plugin Contributor pewgeuges

    (@pewgeuges)

    @a223123131

    Sorry for my late reply. Thank you for the source code. The ARIA label has a URL as value, that is the reason, because I didn’t think at ARIA labels.

    The development v2.2.0d3 is now superseded by 2.2.0d4 and I beg your pardon because the settings were partly redesigned but I got the code wrong, so 2.2.0d4 reverts the dashboard to the previous and works. Please use this at https://downloads.www.ads-software.com/plugin/footnotes.zip and disable the URL wrap while I’ll include aria labels in the exclusion, and whatever else.

    Sorry for this immature solution. If all browsers did conform to the Unicode Standard, I never had to add the <?span class=”footnote_url_wrap”?> around URLs, because Firefox correctly breaks URLs at slashes. but Chrome does not, and several websites have had display bugs, especially on mobiles, because of URLs not line-wrapping.

    I’ll post this and look forward to your feedback while implementing the missing exclusion rules.

    Best regards.

    • This reply was modified 3 years, 11 months ago by pewgeuges.
    • This reply was modified 3 years, 11 months ago by pewgeuges.
    Plugin Contributor pewgeuges

    (@pewgeuges)

    @a223123131

    Catching up on your previous replies: If you have a confidential URL you are welcome to email it; if I shall receive it please use my ID to send it at Gmail.

    The shortcode with double brackets seems to result in URLs that are sort of mangled too, because after removing the URL wrap spans, it doesn’t make sense either. Which plugin are you using to generate hyperlinks from double bracketed strings?

    Plugin Contributor pewgeuges

    (@pewgeuges)

    The hopefully definite fix is a catch-all to exclude any URL preceded by a character (quote) preceded by an equals sign preceded by any word character. It is available in our current v2.2.0d5 at https://downloads.www.ads-software.com/plugin/footnotes.zip

    Best regards.

    Thread Starter a223123131

    (@a223123131)

    Thanks so much @pewgeuges

    It’s funny, I’m using Firefox and have had the issue with Firefox.

    However, I saw your update 2.1.6 and installed it. The issue is fixed ?? I didn’t tryied your 2.2.x versions now. If 2.1.6 is working now, I think it’s better to keep on the official one.

    +Again, thanks so much for the quick fix.

    Plugin Contributor pewgeuges

    (@pewgeuges)

    Hello,

    Thanks a lot for your feedback, and for helping get this regex right! No you don’t need any of the past 2.2.x, numbered so because the target was a retranslated 2.2.0. As the bugfixes have precedence, our latest is 2.1.6.

    Sadly since that span was around visible URLs, Firefox suffers from a fix designed for Chrome. It prevents Firefox from readably breaking URLs at slashes.

    The bug you reported was in the simplistic way I’d implemented that other bug’s fix. Sorry for that mishap.

    Thank you for your quick report!

    Thread Starter a223123131

    (@a223123131)

    Sometimes things are tricky.. Have this on and on that I try to fix something and need to fix the fix of the fix first ??

    Plugin Contributor pewgeuges

    (@pewgeuges)

    Indeed. Thank you for easing my pain!

Viewing 14 replies - 1 through 14 (of 14 total)
  • The topic ‘Broken layout starting version 2.1.4’ is closed to new replies.