Some neat missing features and a bug

Hey there again,

found the fix for the bug:
Line 383 in page-takeover/includes/general.php
.. the “echo” is missing:
Should be:
<?php if ( ! empty( page_takeover_get_option( 'custom_css' ) ) ) echo page_takeover_get_option( 'custom_css' ); ?>

Best regards,
Mike

Hey there,

another missing features would be:
5. Option to set the session cookie “page_takeover_campaign” only after clicking decline and/or the main button.

Hi @mikeknappe

Thanks, happy to hear you like it.

And thanks for the suggestions, will add that to the to do list and pass it on to the plugin owner for review.

Hi @wpkube

Thanks for sharing it with the owner for review.

6. Another neat hint would be to insert a “background div” within ‘page-takeover’ right before ‘page-takeover-container’ to set fullscreen background images with all possibilities like blend-mode and non-inherited opacity.

<div id="page-takeover-output" class="page-takeover" ...

  <div id="page-takeover-cover" class="page-takeover-cover"></div>

  <div id="page-takeover-container"

.page-takeover-cover
{
  background-image: url('some image');
  width: 100%;
  height: 100%;
  background-blend-mode: lighten;
  background-repeat: no-repeat;
  background-attachment: fixed;
  background-position: center;
  background-size: cover;
  position: relative;
  top: 0;
  left: 0;
  transform: none;
  opacity: 0.7;
}
 

• This reply was modified 4 years, 2 months ago by mikeknappe.

It’s me again,

hopefully the last idea ??

7. Option to set a fadeOut for the page-takeover instead of a simple hide.

jQuery( '.page-takeover' ).fadeOut( 500 );

Thanks @mikeknappe

Will pass those as well to the owner.