• Resolved egornmore

    (@egornmore)


    Hello!
    I used to have <amp-base-carousel> unit with current settings:

    type=”silde”
    layout=”responsive”
    width=”2″
    height=”1″
    heights=”(min-width: 600px) and (max-width: 899px) and (orientation: landscape) 370px,
    (min-width: 600px) and (max-width: 1024px) and (orientation: portrait) 450px,
    (min-width: 1025px) 480px, 480px”

    And it was working fine, the carousel was 480px height after 1025px, and all other heights media were working as they should work regardless of slide width. It was ignoring width=”2″ and height=”1″, for some reason. But now it’s ignoring heights media setting and getting values from width=”2″ and height=”1″ and becomes responsive (so height decreasing on width change respectively). I’ve tried layout=”fixed” layout=”fixed-height” but carousel just don’t show up. How I can use heights in v2.1?

    • This topic was modified 3 years, 6 months ago by egornmore.
Viewing 11 replies - 1 through 11 (of 11 total)
  • I don’t believe there were any changes made to version 2.1 that would impact the any amp-base-carousel markup. If you’d like to share the full markup however I’d be happy to check your implementation.

    Thread Starter egornmore

    (@egornmore)

    @jamesosborne I see, here is the markup for my slider in the first screenshot, except width/height (it was width=”2″ and height=”1″) and heights media was overriding it somehow. Trying to figure out which layout I have to use now in order to make heights media work.

    Markup (SC-1): https://ibb.co/8cnXbL6
    Frontend: https://ibb.co/gwLnDFF
    Frontend Responsive: https://ibb.co/94mNCBL

    Thanks for the update. It’s not easy to troubleshooting without adding similar markup on my own site, and the markup is contained within an image. Can you share the markup for your amp-base-carousel and the URL where you have this inserted if possible? You can use this form to share privately if preferred.

    Thread Starter egornmore

    (@egornmore)

    @jamesosborne Submitted form with markup in text format and all additional data

    Excellent! Please allow me some time and I’ll review it before responding to you here.

    Thread Starter egornmore

    (@egornmore)

    @jamesosborne Sure, thank you!

    Thanks for your patience on this. I played around with the code snippet you provided and created a codepen with a possible solution, which uses a responsive layout although a different heights format.

    The same markup should work the same in the latest version of the AMP plugin comparted to prior versions. I also didn’t see any noticeable different with your own code snippet in different versions of the plugin so I can’t say what was occurring.

    Let me know once you test it out anyway.

    Thread Starter egornmore

    (@egornmore)

    Hi @jamesosborne, thank you for investigating my issue! I’ve checked your codepen and was playing around with px and %, then I double-checked all my page content and noticed that amp-base-carousel unit was grouped with other 5 units which were placed before, so my 100% height of parent in CSS took 100% of that group height. Probably that happened accidentally when my teammates changed some content. I apologize for the false report about v2.1. =( Everything works fine now, video attached, thanks!

    https://streamable.com/plpn8u

    No problem whatsoever, you had quite a complex setup to test! Great to hear it’s working now, and very nice implementation. Once your happy with your site and it’s live on it’s final domain you may wish to submit your site for inclusion on the plugins showcase page.

    If you have any further plugin queries be sure to get in touch. And if you have a moment free we’d love to hear how you’re finding the plugin so far.

    Thread Starter egornmore

    (@egornmore)

    Thank you @jamesosborne for all the support. We would love to feature on your showcase page, as a matter of fact, we hoped for it, hence we are developing so meticulously.

    It’s almost certain that I will continue to bother you with other questions, hopefully it doesn’t become a nuisance and is productive for all.

    Once again, thanks for your time.

    Well that’s what we’re here for, no bother at all! While we won’t be able to assist with component setups anything plugin related we’re happy to help. And judging by your site as it was when I checked I think you’d be a great fit for marketing team to review for listing on the showcase section.

Viewing 11 replies - 1 through 11 (of 11 total)
  • The topic ‘AMP Base Carousel Settings Issue v2.1’ is closed to new replies.