Shortcodes there are problems and plus modernization.

Hi dear!
I am creating a store with over 3000 brands.
1. If you display the shortcode [pwb-carousel items = "1000" items_to_show = "10" items_to_scroll = "1" arrows = "true" hide_empty = "false" image_size = "medium" autoplay = "false"], then on older browsers (for example PaleMoon) the Javascript hangs up.
2. The hide_empty = "false" parameter does NOT work.
You have a function: public static function get_brands ($ hide_empty = false, $ order_by = 'name', $ order = 'ASC', $ only_featured = false, $ pwb_term = false, $ only_parents = false)
And call it like $ brands_array = \ Perfect_Woocommerce_Brands \ Perfect_Woocommerce_Brands :: get_brands (self :: $ atts ['items']);
Those. the first parameters do not match!
3. Because I have very many brands, then I thought it would be inappropriate to display them all in a carousel. And I got the idea that sorting when displaying in a carousel can not be by name, but by the number of products belonging to the brand, i.e. type of popularity ?? To support this, you only need to change three lines in the plugin code:

    self :: $ atts = shortcode_atts (array (
        'orderby' => "name", // +++++
        'order' => "ASC", // +++++
        'items' => "10",
        'items_to_show' => "5",
        'items_to_scroll' => "1",
        'image_size' => "thumbnail",
        'autoplay' => "false",
        'arrows' => "false",
        'hide_empty' => false
    ), $ atts, 'pwb-carousel');

AND
$ brands_array = \ Perfect_Woocommerce_Brands \ Perfect_Woocommerce_Brands :: get_brands (self :: $ atts ['items'], self :: $ atts ['orderby'], self :: $ atts ['order']);

• This topic was modified 3 years, 3 months ago by igora100.