Undefined array key “path” in class-change-wp-admin-login.php on line 282

Hi @deksar

First of all thank you for using the plugin.
There are no errors they are warnings, which php version are you using?

Best,
Nuno

Hi Nuno, thank you!

I’m on PHP 8.0.13. Please let me know if you need to know anything else on that matter.

Best.

• This reply was modified 2 years, 12 months ago by Andreas.

I think I can now reproduce the warning,
A GET request like: /?author=1 doesn’t give any PHP warning.
but a GET request like: //?author=1 gives the PHP warning above.

So typing: mysite.com/ will not give any warning.
but typing: mysite.com// will give the warning.

“PHP message: PHP Warning: Trying to access array offset on value of type bool in /wp-content/plugins/change-wp-admin-login/includes/class-change-wp-admin-login.php on line 282

PHP message: PHP Warning: Trying to access array offset on value of type bool in /wp-content/plugins/change-wp-admin-login/includes/class-change-wp-admin-login.php on line 290” server: mysite.com, request: “GET // HTTP/2.0”

Also; visiting: mysite.com//.env
gives such error: PHP Warning: Undefined array key “path” in /change-wp-admin-login/includes/class-change-wp-admin-login.php on line 282

Can this help?

Thanks.

• This reply was modified 2 years, 12 months ago by Andreas.
• This reply was modified 2 years, 12 months ago by Andreas.
• This reply was modified 2 years, 12 months ago by Andreas.

Hi @deksar

Thank you for troubleshooting the php warning .

The warning that you are seeing wont have any implications in how your WordPress and plugins works. It just telling you that it didn’t capture the extra forward slash that you are adding to the URL. In normal conditions no one adds an extra forward slash on the URL path – thats a typo and it should give you a 404 page.

I’m closing this support request because there is nothing wrong with the plugin code, is just you are wrongly typing the URL address.

Best,
Nuno

After upgrading from PHP7 to PHP8, almost all my plugins were giving such warning. I reported them and they all fixed it. However the author of this plugin insists to ignore it.

@deksar you are more than welcome to contribute and fix the plugin. The plugin is free for everyone you can edit, change and fix it accordingly. The PHP warning that you are seeing it wont affect the functionality of the plugin or any functionality of your website.

I had to switch away from this plugin as it made PHP-FPM processes hang, and use up 80-90% of the VCPU on my server, until it stopped after 30 minutes.
So it’s not just a simple warning, it’s a bug.

Hi @towytowy

I’m sorry to hear that you are having issues with my plugin. Could you please share the logs that is showing that my plugin is causing this “PHP-FPM processes hang, and use up 80-90% of the VCPU” ?

I’m using the latest php version on my personal website and in another 200+ on my clients and agency that I work for and I’m afraid that I don’t have that issue in all these websites, plus there are 70.000 active installations of this plugin and this issue never was reported to me. If you supplied the logs from the server stating that my plugin is giving you those issues I’m more than happy to fix it for you.

It seems you have reported the “same issue” on this plugin:
https://www.ads-software.com/plugins/ultimate-dashboard/
https://www.ads-software.com/support/topic/php-message-php-warning-undefined-array-key-path/

Best,
Nuno

• This reply was modified 2 years, 7 months ago by Nuno Sarmento.

I know this is slightly old news, but to clarify, I also had high CPU usage (only 24%); however, when I removed the “Change wp-admin login” plugin for a different plugin, instantly my CPU dropped to less than 1%.

Hi @nunosarmento first of all, thanks for all the effort you put into this plugin.

We are facing the same error on our site(s). The issue is basically either users are incorrectly typing these types of URLs, or spam bots are trying to look for weaknesses on the site.

We have no control over what users type in the address bar, but we do have control over our code, so we should mitigate it there if we are able to do so.

I’m a plugin maintainer myself, and will be happy to fix this issue for you if you have a Git repository somewhere? Happy to create a Pull Request.

Let me know what you think!

Hu @junaidbhura

Thank you for your message.
There is no git for the project – if you want to help, please send me your fix and I will have look at it.

Best,
Nuno

Hello @nunosarmento

Thanks for creating this plugin.

I have created a patch file which should address the issue. Please check the below link.

Patch: https://gist.github.com/dhaval-parekh/d52bfcf66202ff2d8ae1784364350814

Let me know if there is anything.

Thank you
Dhaval Parekh

Hi @dhaval-parekh,

This Patch is crashing my site:

[Fri Nov 04 08:57:17.580435 2022] [php:error] [pid 76541] [client 173.252.111.118:42728] PHP Fatal error: Uncaught TypeError: Unsupported operand types: string * int in /var/www/***/htdocs/wp-content/plugins/change-wp-admin-login/includes/class-change-wp-admin-login.php:288\nStack trace:\n#0 /var/www/***/htdocs/wp-includes/class-wp-hook.php(308): Change_WP_Admin_Login->plugins_loaded()\n#1 /var/www/***/htdocs/wp-includes/class-wp-hook.php(332): WP_Hook->apply_filters()\n#2 /var/www/***/htdocs/wp-includes/plugin.php(517): WP_Hook->do_action()\n#3 /var/www/***k/htdocs/wp-settings.php(480): do_action()\n#4 /var/www/***/htdocs/wp-config.php(113): require_once('...')\n#5 /var/www/***/htdocs/wp-load.php(50): require_once('...')\n#6 /var/www/***/htdocs/wp-blog-header.php(13): require_once('...')\n#7 /var/www/***/htdocs/index.php(17): require('...')\n#8 {main}\n thrown in /var/www/***/htdocs/wp-content/plugins/change-wp-admin-login/includes/class-change-wp-admin-login.php on line 288

Any ideas?

Thank you very much,

Roger

• This reply was modified 2 years ago by rogerpz81.

Hi @rogerpz81,

Which PHP version are you running? Can you please show me your fix here to see what you have done ?

Thank you,

Nuno

Hi @dhaval-parekh.

Thank you for taking your time for trying to fix the php warning.

Did you test your patch ? Which php version are you running ?

Thank you again

Nuno