Poor code cleanup

  • Resolved arwooga

    (@arwooga)


    2 years, 11 months ago

    So what’s up with the fake reviews of this theme? I mean, if you deactive the theme and the associated hivepress plugin, and active another theme, this themes footer stays resident! Deleting the theme and plugin renders the site unable to load obviously because wordpress is calling part of their footer from changes they have made to core wordpress files. So what core wordpress files have you changed that calls your theme’s footer? And why isnt wordpress onto this, as changing core wordpress files from a theme is a no-no.

Viewing 3 replies - 1 through 3 (of 3 total)
  • Theme Author HivePress

    (@hivepress)

    Hi,
    I’m sorry if you had a bad experience. There’s no function in the theme that may affect the WordPress core files or the header/footer design if you switch the theme. We 100% follow the WordPress theme development guidelines (and also WP coding standards, which is rare for themes around here). The issue you described may occur if:
    – Another theme registers the footer widget area with the same name “footer”, so widgets you added to the footer (or imported with demo content) may remain if you switch the theme. In this case please simply remove widgets from the footer area in Appearance/Widgets section.
    – There’s a caching plugin or server-side caching solution that still displays some parts of the design even if you changed the theme. In this case please try disabling all the caching solutions or clear the cache.

    Thread Starter arwooga

    (@arwooga)

    Hi, I am not using any caching at the moment. That doesn’t explain why deleting your theme and hivepress pluging caused the site to hang on loading when another preinstalled theme was activated. If it was cached, your footer would still be there lol. So either your theme or hivepress was trying to reference a footer (php or css maybe?) from your theme that was no long available (as they were deleted). Removing your footer (and fixing the hang on load) was simply done by reinstalling the new theme which also proves it’s not a caching issue. If your demo content is creating resident references to widgets in your theme while another theme is activated, then there’s a problem. It’s cool, you seem to think that’s ok to have resident references back to your themes files when another theme is activated, so I will just leave it at that, and provide my feedback.

    Theme Author HivePress

    (@hivepress)

    Thanks for the details.
    If you disable both the theme and the plugin then its code is no longer executed, and since the theme/plugin doesn’t make any changes in the WordPress core files (ListingHive/HivePress code is open-source and available on Github so anyone can check it) this issue shouldn’t occur – I guess it’s a widget area conflict (if both themes use the same widget area name then widgets will stay there if you switch themes) or maybe a conflict with a third-party plugin.
    The demo content itself doesn’t reference any theme-specific widgets – ListingHive doesn’t have these, there are only default WordPress text/menu widgets in the footer area.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Poor code cleanup’ is closed to new replies.

Tags