BUG – featured image, version 1.0.77.35

  • Resolved SeyMedia

    (@seymedia)


    3 years, 1 month ago

    So… You have a bug in your plugin:
    file accelerated-mobile-pages/components/featured-image/featured-image.php
    line 77:
    $amp_html = '<amp-img data-hero src="'.esc_url($image[0]).'" srcset="'.esc_html($srcet).'" width="'.esc_attr($image[1]).'" height="'.esc_attr($image[2]).'" layout=responsive alt="'.esc_attr($alt).'"></amp-img>';

    layout=responsive need to be layout=”responsive”
    If you don’t put “” then you might have a problem in next part, where is the image’s alt, this might not display with the “” and Google Search Console will see it like an error in the amp structure.

    https://amp.dev/documentation/guides-and-tutorials/learn/amp-html-layout/?format=websites
    You can see here how is correct!

    • This topic was modified 3 years, 1 month ago by SeyMedia.
Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author Ahmed Kaludi

    (@ahmedkaludi)

    For this, We already have a GitHub ticket in our repository. We will work on it and fix it soon and let you know back.

    Reference ticket: https://github.com/ahmedkaludi/accelerated-mobile-pages/issues/5207

    Thread Starter SeyMedia

    (@seymedia)

    Also, why do you modify some css from the normal WP’s css?
    File:
    plugins/accelerated-mobile-pages/includes/admin-style.css
    line 2193

    .updated.notice p {
    font-size: 15px;
}

    This affects the message from the editor that shows when you update a post or page, it’s shows the text bigger than normal.

    Plugin Author Ahmed Kaludi

    (@ahmedkaludi)

    We tested it from our end but did not get any issue as you mentioned. If possible, Can you please share a short video of the issue for reference purposes once? So that we will go through it and get back to you shortly.

    Thread Starter SeyMedia

    (@seymedia)

    Sorry, i can’t make a video right now, but here are some screenshots:

    With the css from your plugin

    View post on imgur.com

    Without the css from your plugin

    View post on imgur.com

    The section with the problem is the “Post updated” message.
    It’s installed the latest version of WP, AMP for WP and Classic Editor.

    The WP css for that part:
    font-size: 13px;

    AMP for WP:
    font-size: 15px;

    Plugin Author Ahmed Kaludi

    (@ahmedkaludi)

    Thanks for sharing in detail. We will check it from our end and get back to you shortly.

    Plugin Author Ahmed Kaludi

    (@ahmedkaludi)

    We fixed the issue in our latest update 1.0.77.36. Can you please check it once by updating the AMPforWP plugin to the updated version and let me know if it fixes your issue or not?

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘BUG – featured image, version 1.0.77.35’ is closed to new replies.