False positive warnings for Image Source Control Pro

Hello @webzunft

Thank you for contacting us, As we checked your data we found that the following file might be adding the custom script which is not allowed on AMP.

pro/public/public.php Line 117 hooked with wp_print_footer_scripts

As we don’t have access to the pro plugin we can’t be sure what could be the exact cause of the error. if the script is being included we will recommend add an exception for AMP pages using amp_is_request check

eg:

if ( function_exists( 'amp_is_request' ) && amp_is_request() ) {
   // do something only on AMP page.
}

We also noticed that you are using Blocksy which is the non-AMP compatible theme, which may put some underlying validation errors.

Additionally, we will recommend checking AMP compatibility with a compatible theme such as twentytwentyone while deactivating other plugins (keep only AMP and ISC active with twentytwentyone theme)

Let us know if you need further assistance!

Hey Milind,

thanks for your reply.

Using the TwentyTwentyOne theme does not throw an error.

ISC should not do any output, especially not, as the error I saw, add any script tags on AMP. This is why I reported it as a “false positive”.

It seems to be connected to ISC using output buffering. Let me know if you would like to take a look and how I can send you a copy of ISC.

Thanks,
Thomas

Sure, I am happy to test it and contribute to it if needed.

You can send me invite on Github my id is milindmore22 or you can send me a copy of the plugin using this form (use last field in the form)

Thanks, I just added you to the repo. The last logged issue is the relevant one.

Hello @webzunft

Thank you for providing access, As I checked your plugin we didn’t find any validation issues, we also didn’t find any false positive reports due to third-party plugins and themes.

The invalid inline script is pointing correctly to Blocksy theme (screenshot)

The Blocksy also removes src attributes (for some lazy load :|) from images creating missing required attributes error (screenshot)

I didn’t encounter any error while using it with Twenty Twenty One, Twenty Twenty, Neve, Astra (AMP-compatible themes )

Let me know if you like to list ISC in our AMP ecosystem.

We will be happy to have a new addition.