Why Tawk embed code migration is execute in all the pages?

  • So investigating all the DB interactions, 

    if ( class_exists( 'TawkTo' ) ) {
	register_activation_hook( __FILE__, array( 'TawkTo', 'activate' ) );
	register_deactivation_hook( __FILE__, array( 'TawkTo', 'deactivate' ) );

	$tawkto = new TawkTo();

	$upgrade_manager = new TawkToUpgradeManager(
		TawkTo::get_plugin_version(),
		TawkTo::PLUGIN_VERSION_VARIABLE
	);
	$upgrade_manager->register_hooks();

	if ( isset( $tawkto ) ) {
		// these are called every page load.
		$tawkto->migrate_embed_code();

    This code is executed in all the pages backend/frontend and don’t make sense.
    As it is something that should happen on update or activation.

Viewing 3 replies - 1 through 3 (of 3 total)

  • Hi Daniele,

    Thank you for choosing tawk.to and for reaching out.

    The reason that we currently have that kind of setup in our plugin is that we don’t have tracking of the plugin version before in the database. So if we placed the migration script before in the update part of the plugin, the migration script won’t run because the plugin will not know what update it should run.

    We currently approached it that way so that the migration will happen seamlessly. The migration will only trigger once. After that, the migration won’t trigger again.

    If you have any tawk.to related concerns, we invite you to reach out on our 24/7 support line. Our live agents are always available to assist you. Alternatively, you can reach me here at [email protected].

    You can also email our support line at [email protected]

    I see but the code is not executed once, is executed in all the pages.
    Is not executed during the activation but as you can see in this code is executed at every plugin loaded in wordpress so in all the pages.
    Infact as you can see there is a comment in the plugin: // these are called every page load. > https://plugins.trac.www.ads-software.com/browser/tawkto-live-chat/trunk/tawkto.php#L627

    It should have more sense, a button in the settings that executed this code just once so the user can do it manually. Or during the upgrade as it is just get an option in the db and execute a regex with updating and removing of that.

    A ping as I saw that was released a new version but this problem wasn’t sorted out.

    [Moderator note: Please, No bumping].

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Why Tawk embed code migration is execute in all the pages?’ is closed to new replies.