• Resolved markva

    (@markva)


    Hi,

    Thanks for the useful plugin.

    The issue I have is the close icon not showing.

    Please advice.

    The page I need help with: [log in to see the link]

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author wpexplorer

    (@wpexplorer)

    Hi,

    This is AJ the plugin author.

    It looks like your site is rendering using AMP code (even on desktop) and the “x” icon is disabled when the AMP plugin is in use to prevent issues. This was actually done as a request from the AMP plugin developers themselves.

    If you disable AMP does the close button show up correctly? You could test to confirm.

    – AJ

    ps: I was clicking around your site and noticed that your mobile menu can’t be closed once it’s opened.

    Thread Starter markva

    (@markva)

    Hey AJ!

    I have just tested with AMP disabled and the X does show:

    View post on imgur.com

    I wish it would also show in AMP, because your (great) plugin is labelled “AMP Compatible”.

    Regarding my site’s menu: Using my S10 I have no issues with the menu.

    What device are you using?

    Thanks,
    Mark

    Thread Starter markva

    (@markva)

    I forgot to say I am using AMP in standard mode (all is AMP).

    Plugin Author wpexplorer

    (@wpexplorer)

    Hi Mark,

    The AMP compatibility is provided by the plugin itself, they are the ones that gave me the code to specifically disable the close button when their plugin is enabled and the current request is an AMP request. I think it has to do with the fact that certain javascript functions need to be removed for AMP pages. This would be something to ask the plugin developers about if curious.

    Either way, the close button should display on the desktop version of the site (non AMP page) because the code they told me to add in my plugin specifically uses the amp_is_request() to disable the close button and related javascript, which means if you aren’t seeing the button on non-amp pages perhaps there is an issue with your setup.

    – AJ

    ps: Regarding the mobile menu seems to be working now, previously the close button wasn’t there – https://a.cl.ly/4guKobJq – that said, your mobile menu is not coded with accessibility in mind – not sure what theme you are using but you may want to reach out to them at let them know since accessibility is very important. For example you should be able to hit the esc button to close the mobile menu and when tabbing through the mobile menu the focus should remain within the mobile menu.

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Close Icon Not Showing’ is closed to new replies.