101 jiliph.Claim Your Free 999 Pesos Bonus Today

Zoker
(@zoker)

2 years, 5 months ago

Hi Ultimate Member-Team,

I submitted a PR to FriendlyCaptcha (with a little fix here) and to hCaptcha, in order to integrate them with ultimate member forms.

But I have a specific issue, that occurs with both integrations:
When UM login (to protect UM login page) and WordPress login (to protect native wordpress login) settings are both enabled in either integration, the captcha request seems to be sent twice and therefore the second (important) call is reject as duplicate. My guess is, that UM hooks into the wordpress login system and then somehow triggers a second captcha verification process.

Can you please guide me how to fix this, so both integrations can work without issue?
Here is an example, how the FriendlyCaptcha Ultimate Member Login form is protected:
https://github.com/FriendlyCaptcha/friendly-captcha-wordpress/blob/main/friendly-captcha/modules/ultimate-member/ultimate-member_login.php

Is there anything wrong in this code? How can I avoid sending two requests, when there should only be one?

Thanks!

PS: I hope this is clear, but I tested both integrations independently with only one of the captcha plugins turned on at the same time. But since I have clients using hCaptcha and clients using FriendlyCaptcha I tried to add integration for both.

Viewing 5 replies - 1 through 5 (of 5 total)

missveronica
(@missveronicatv)

2 years, 5 months ago

@zoker

You can try this UM hCaptcha integration:

https://github.com/MissVeronica/hCaptcha-addon-for-Ultimate-Member-plugin
Thread Starter Zoker
(@zoker)

2 years, 5 months ago
Hi @missveronicatv

Thanks for the hint, but this post is not about using another plugin, but integrating Um with general captcha plugins. And there seems to be a internal logic, that I don’t know, which causes the above issues. And since only these mentioned plugins use both a UM integration and a wordpress native form integration, this issue appears.
So I would appreciate if one of the devs could give me a hint about this. so I can create a PR and fix this for all the existing plugin users.
Maybe @aswingiri or @ultimatemembersupport could give me a hint here

Edit:
I think I found the issue:
It’s these two lines:
Here and here

Here is what I understood so far:
UM hooks into wp_authenticate_user and authenticate and since this triggers the captcha native integration for example here this leads to the captcha request get’s send twice to the captcha provider and will fail. Currently I have no clue how to handle that. Can somebody guide me here? Thanks!
- This reply was modified 2 years, 5 months ago by Zoker.
- This reply was modified 2 years, 5 months ago by Zoker.
- This reply was modified 2 years, 5 months ago by Zoker.
- This reply was modified 2 years, 5 months ago by Zoker.
Plugin Support Ultimate Member Support
(@ultimatemembersupport)

2 years, 4 months ago

Hi @zoker

It looks like they have added this code to prevent duplicate triggers?
https://github.com/FriendlyCaptcha/friendly-captcha-wordpress/blob/main/friendly-captcha/modules/wordpress/wordpress_login.php#L50

Are you using the master version?

Plugin Support Ultimate Member Support
(@ultimatemembersupport)

2 years, 4 months ago

Hi @zoker

Also, please try commenting this line in the UM core file and see if the issue still the same:
https://github.com/ultimatemember/ultimatemember/blob/master/includes/core/class-user.php#L1129

Regards,
Thread Starter Zoker
(@zoker)

2 years, 4 months ago
Hi @ultimatemembersupport,

Yes it was me who added this code to the FriendlyCaptcha plugin as well as to the hCaptcha plugin.

Can you please have a look at those two code changes and tell me, if they are correct/the best way to implement this? Thanks!
- https://github.com/FriendlyCaptcha/friendly-captcha-wordpress/pull/49
- https://github.com/hCaptcha/hcaptcha-wordpress-plugin/pull/167

Viewing 5 replies - 1 through 5 (of 5 total)

The topic ‘FriendlyCaptcha & hCaptcha integration issue’ is closed to new replies.