BUG: Exporting templates uses wrong “theme” key

+1

The “theme” key assigned to the template parts breaks the templates in the editor, presumably because it now uses the site name instead of the theme name.

Hi @markhowellsmead and @spacedragon there is an open issue for this bug, you can keep track of the progress here: https://github.com/WordPress/create-block-theme/issues/242

Feel free to add your experience there.

Thanks for the swift feedback.

Thanks for reporting this. This issue was fixed in the recently launched version 1.6.1.
Please, update the plugin to try it.
I’m marking this as resolved. Feel free to re-open if your issue persists.

Can confirm that the issue has been resolved. Thanks!

@spacedragon Great, thanks for confirming that this is now fixed!

The error no longer occurs, but saving the changes from the editor now removes the theme key from the saved HTML altogether. I think this is OK, but I’m not sure of the consequences…

@mmaattiiaass – perhaps you could chime in on @markhowellsmead’s comment above? Thanks!

Hi @markhowellsmead, I’m could you add more details about your latest comment? Thanks!

Sure, what information would you like?

@markhowellsmead as far as I could test; there are two scenarios:

– Linking template-parts from templates:
In this case, the presence/absence of the theme key doesn’t change the correct template part loading.

– Linking template parts from patterns:
In this case, the theme key needs to be there to load the template-parts correctly.

In the latest version of the plugin, we include the theme key in both cases.

I don’t know if this answers your question. Let me know.

• This reply was modified 1 year, 8 months ago by Matias Benedetto.