PHPCS errors preventing plugin update

  • Resolved spinksys

    (@spinksys)


    1 year, 9 months ago

    Hi, I’m currently trying to update WordPress Popular Posts from 6.0.5 to 6.1.1, but I’m unable to due to a large number of PHP code sniffer errors. In the past I’ve fixed most of them myself, but as they are mostly security related it’d be best if they were fixed in the code base and released to the community. Here are the errors, please let me know if there’s anything I can do to help:

    myusername@Q-C02DQ30GMD6R-myusername blankslate % phpcs --standard=WordPress-VIP-Go -sp --basepath=. --ignore=vendor ../../plugins/wordpress-popular-posts -n
..E....S.....S...........EE......EEEEE.....E.EEEE....E.E.ES. 60 / 66 (91%)
......                                                       66 / 66 (100%)



FILE: Users/myusername/workspace/vagrant-local/www/mywebsite-wp/public_html/wp-content/plugins/wordpress-popular-posts/uninstall.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 8 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------------
 27 | ERROR | Overriding WordPress globals is prohibited. Found assignment to $blog_id (WordPress.WP.GlobalVariablesOverride.Prohibited)
 58 | ERROR | Filesystem writes are forbidden, please do not use rmdir(). (WordPressVIPMinimum.Functions.RestrictedFunctions.directory_rmdir)
 75 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $prefix at "DROP TABLE IF EXISTS {$prefix}data;"
    |       | (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
 76 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $prefix at "DROP TABLE IF EXISTS {$prefix}datacache;"
    |       | (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
 77 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $prefix at "DROP TABLE IF EXISTS {$prefix}datacache_backup;"
    |       | (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
 78 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $prefix at "DROP TABLE IF EXISTS {$prefix}log;"
    |       | (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
 79 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $prefix at "DROP TABLE IF EXISTS {$prefix}summary;"
    |       | (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
 80 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $prefix at "DROP TABLE IF EXISTS {$prefix}transients;"
    |       | (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
-------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: Users/myusername/workspace/vagrant-local/www/mywebsite-wp/public_html/wp-content/plugins/wordpress-popular-posts/src/Widget/form.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 119 ERRORS AFFECTING 62 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------------
   7 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
   8 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
   8 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  13 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  14 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  14 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  19 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  20 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  20 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  32 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  33 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  33 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  42 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  42 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  44 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  44 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  52 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  52 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  52 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  54 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  55 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  55 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  57 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  58 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  58 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  60 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  76 | ERROR | Overriding WordPress globals is prohibited. Found assignment to $taxonomy (WordPress.WP.GlobalVariablesOverride.Prohibited)
  79 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  80 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  88 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  89 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  89 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  98 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  98 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  98 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 101 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 101 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 101 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 104 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 104 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 104 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 105 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 106 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 109 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 109 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 109 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 112 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 112 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 112 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 113 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 113 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 113 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 115 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 116 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 119 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 119 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 119 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 122 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 124 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 124 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 135 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 137 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 138 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 138 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 140 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 141 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 141 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 149 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 149 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 149 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 151 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 151 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 151 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 153 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 153 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 153 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 155 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 155 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 155 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 160 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 161 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
     |       | 'get_option'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
 161 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 161 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
     |       | 'date_i18n'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
 161 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
     |       | 'admin_url'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
 162 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 162 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
     |       | 'date_i18n'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
 163 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 163 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
     |       | 'date_i18n'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
 164 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 164 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
     |       | 'date_i18n'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
 165 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 165 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
     |       | 'date_i18n'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
 168 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 168 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 168 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 174 | ERROR | Overriding WordPress globals is prohibited. Found assignment to $taxonomy (WordPress.WP.GlobalVariablesOverride.Prohibited)
 178 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 191 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 191 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 191 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 206 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 207 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 207 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 207 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 207 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 209 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 210 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 210 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 210 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 210 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 212 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 213 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 213 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 213 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
     |       | '$instance['markup']['post-html']'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
 219 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '__'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 226 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 226 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 232 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 232 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
-------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: Users/myusername/workspace/vagrant-local/www/mywebsite-wp/public_html/wp-content/plugins/wordpress-popular-posts/src/Widget/Widget.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------------
 142 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
     |       | '$before_widget'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
 153 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
     |       | 'htmlspecialchars_decode'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
 153 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$title'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 153 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
     |       | 'htmlspecialchars_decode'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
 155 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
     |       | '$before_title'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
 155 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$title'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 155 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
     |       | '$after_title'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
 172 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
     |       | '$after_widget'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
-------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: Users/myusername/workspace/vagrant-local/www/mywebsite-wp/public_html/wp-content/plugins/wordpress-popular-posts/src/Admin/admin-page.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 31 ERRORS AFFECTING 27 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------------
   2 | ERROR | Detected usage of a possibly undefined superglobal array index: $_SERVER['SCRIPT_NAME']. Use isset() or empty() to check the index exists
     |       | before using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated)
   5 | ERROR | Overriding WordPress globals is prohibited. Found assignment to $tabs (WordPress.WP.GlobalVariablesOverride.Prohibited)
  25 | ERROR | Detected usage of a possibly undefined superglobal array index: $_POST['stats_limit']. Use isset() or empty() to check the index exists
     |       | before using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated)
  25 | ERROR | Detected usage of a possibly undefined superglobal array index: $_POST['stats_limit']. Use isset() or empty() to check the index exists
     |       | before using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated)
  25 | ERROR | Detected usage of a possibly undefined superglobal array index: $_POST['stats_limit']. Use isset() or empty() to check the index exists
     |       | before using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated)
  30 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '__'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  37 | ERROR | Detected usage of a possibly undefined superglobal array index: $_POST['link_target']. Use isset() or empty() to check the index exists
     |       | before using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated)
  38 | ERROR | Detected usage of a possibly undefined superglobal array index: $_POST['css']. Use isset() or empty() to check the index exists before using
     |       | it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated)
  42 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '__'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  50 | ERROR | Detected usage of a possibly undefined superglobal array index: $_POST['thumb_source']. Use isset() or empty() to check the index exists
     |       | before using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated)
  53 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '__'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  61 | ERROR | Detected usage of a possibly undefined superglobal array index: $_POST['thumb_source']. Use isset() or empty() to check the index exists
     |       | before using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated)
  64 | ERROR | Detected usage of a possibly undefined superglobal array index: $_POST['thumb_field_resize']. Use isset() or empty() to check the index
     |       | exists before using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated)
  65 | ERROR | Detected usage of a possibly undefined superglobal array index: $_POST['thumb_lazy_load']. Use isset() or empty() to check the index exists
     |       | before using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated)
  68 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '__'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  76 | ERROR | Detected usage of a possibly undefined superglobal array index: $_POST['log_option']. Use isset() or empty() to check the index exists before
     |       | using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated)
  77 | ERROR | Detected usage of a possibly undefined superglobal array index: $_POST['log_limit']. Use isset() or empty() to check the index exists before
     |       | using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated)
  78 | ERROR | Detected usage of a possibly undefined superglobal array index: $_POST['log_expire_time']. Use isset() or empty() to check the index exists
     |       | before using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated)
  78 | ERROR | Detected usage of a possibly undefined superglobal array index: $_POST['log_expire_time']. Use isset() or empty() to check the index exists
     |       | before using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated)
  78 | ERROR | Detected usage of a possibly undefined superglobal array index: $_POST['log_expire_time']. Use isset() or empty() to check the index exists
     |       | before using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated)
  79 | ERROR | Detected usage of a possibly undefined superglobal array index: $_POST['ajax']. Use isset() or empty() to check the index exists before using
     |       | it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated)
  83 | ERROR | Detected usage of a possibly undefined superglobal array index: $_POST['cache']. Use isset() or empty() to check the index exists before
     |       | using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated)
  84 | ERROR | Detected usage of a possibly undefined superglobal array index: $_POST['cache_interval_time']. Use isset() or empty() to check the index
     |       | exists before using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated)
  85 | ERROR | Detected usage of a possibly undefined superglobal array index: $_POST['cache_interval_value']. Use isset() or empty() to check the index
     |       | exists before using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated)
  90 | ERROR | Detected usage of a possibly undefined superglobal array index: $_POST['cache']. Use isset() or empty() to check the index exists before
     |       | using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated)
  91 | ERROR | Detected usage of a possibly undefined superglobal array index: $_POST['cache_interval_time']. Use isset() or empty() to check the index
     |       | exists before using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated)
  94 | ERROR | Detected usage of a possibly undefined superglobal array index: $_POST['sampling']. Use isset() or empty() to check the index exists before
     |       | using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated)
 100 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '__'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 110 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
     |       | 'admin_url'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
 111 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
     |       | 'admin_url'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
 112 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
     |       | 'admin_url'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
-------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: Users/myusername/workspace/vagrant-local/www/mywebsite-wp/public_html/wp-content/plugins/wordpress-popular-posts/src/Admin/screen-debug.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 13 ERRORS AFFECTING 11 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------------
  5 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '__'.
    |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 48 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
    |       | '$performance_nag_status'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
 50 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '=='.
    |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 51 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
    |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 59 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
    |       | 'phpversion'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
 60 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
    |       | 'get_loaded_extensions'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
 61 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$wpdb'.
    |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 62 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$wpdb'.
    |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 63 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
    |       | '$wp_version'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
 65 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
    |       | '$plugin_names'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
 66 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$my_theme'.
    |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 66 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$my_theme'.
    |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 66 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$my_theme'.
    |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
-------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: Users/myusername/workspace/vagrant-local/www/mywebsite-wp/public_html/wp-content/plugins/wordpress-popular-posts/src/Admin/screen-tools.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------------
   5 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '__'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 191 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '__'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
-------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: Users/myusername/workspace/vagrant-local/www/mywebsite-wp/public_html/wp-content/plugins/wordpress-popular-posts/src/Admin/screen-stats.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------------
  86 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '__'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 126 | ERROR | Overriding WordPress globals is prohibited. Found assignment to $posts (WordPress.WP.GlobalVariablesOverride.Prohibited)
-------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: Users/myusername/workspace/vagrant-local/www/mywebsite-wp/public_html/wp-content/plugins/wordpress-popular-posts/src/Admin/Admin.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 61 ERRORS AFFECTING 43 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------------
  239 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $prefix at "SHOW FIELDS FROM {$prefix}data;"
      |       | (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
  243 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $prefix at "ALTER TABLE {$prefix}data ALTER COLUMN day DROP DEFAULT;"
      |       | (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
  247 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $prefix at "ALTER TABLE {$prefix}data ALTER COLUMN last_viewed DROP
      |       | DEFAULT;" (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
  252 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $prefix at "SHOW FIELDS FROM {$prefix}summary;"
      |       | (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
  256 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $prefix at "ALTER TABLE {$prefix}summary CHANGE last_viewed view_datetime
      |       | datetime NOT NULL, ADD KEY view_datetime (view_datetime);" (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
  260 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $prefix at "ALTER TABLE {$prefix}summary ALTER COLUMN view_date DROP
      |       | DEFAULT;" (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
  264 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $prefix at "ALTER TABLE {$prefix}summary ALTER COLUMN view_datetime DROP
      |       | DEFAULT;" (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
  268 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $prefix at "SHOW INDEX FROM {$prefix}summary;"
      |       | (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
  272 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $prefix at "ALTER TABLE {$prefix}summary DROP INDEX ID_date;"
      |       | (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
  276 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $prefix at "ALTER TABLE {$prefix}summary DROP INDEX last_viewed;"
      |       | (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
  284 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $prefix at "SELECT ENGINE FROM information_schema.TABLES WHERE
      |       | TABLE_SCHEMA='{$wpdb->dbname}' AND TABLE_NAME='{$prefix}data';" (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
  287 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $prefix at "ALTER TABLE {$prefix}data ENGINE=InnoDB;"
      |       | (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
  290 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $prefix at "SELECT ENGINE FROM information_schema.TABLES WHERE
      |       | TABLE_SCHEMA='{$wpdb->dbname}' AND TABLE_NAME='{$prefix}summary';" (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
  293 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $prefix at "ALTER TABLE {$prefix}summary ENGINE=InnoDB;"
      |       | (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
  364 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $post_type_placeholders at             WHERE p.post_type
      |       | IN({$post_type_placeholders}) AND p.post_status = 'publish' AND p.post_password = '' AND v.view_datetime > DATE_SUB(%s, INTERVAL 1
      |       | HOUR);" (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
  368 | ERROR | Use placeholders and $wpdb->prepare(); found $query (WordPress.DB.PreparedSQL.NotPrepared)
  437 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
      |       | 'plugin_dir_url'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
  493 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
      |       | 'admin_url'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
  493 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '__'.
      |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
  726 | ERROR | date() is affected by runtime timezone changes which can cause date/time to be incorrectly displayed. Use gmdate() instead.
      |       | (WordPress.DateTime.RestrictedFunctions.date_date)
  731 | ERROR | date() is affected by runtime timezone changes which can cause date/time to be incorrectly displayed. Use gmdate() instead.
      |       | (WordPress.DateTime.RestrictedFunctions.date_date)
  906 | ERROR | Use placeholders and $wpdb->prepare(); found $post_type_placeholders (WordPress.DB.PreparedSQL.NotPrepared)
  907 | ERROR | Use placeholders and $wpdb->prepare(); found $this (WordPress.DB.PreparedSQL.NotPrepared)
  907 | ERROR | Use placeholders and $wpdb->prepare(); found config (WordPress.DB.PreparedSQL.NotPrepared)
  907 | ERROR | Use placeholders and $wpdb->prepare(); found ? (WordPress.DB.PreparedSQL.NotPrepared)
  907 | ERROR | Use placeholders and $wpdb->prepare(); found : (WordPress.DB.PreparedSQL.NotPrepared)
  915 | ERROR | Use placeholders and $wpdb->prepare(); found $post_type_placeholders (WordPress.DB.PreparedSQL.NotPrepared)
  916 | ERROR | Use placeholders and $wpdb->prepare(); found $this (WordPress.DB.PreparedSQL.NotPrepared)
  916 | ERROR | Use placeholders and $wpdb->prepare(); found config (WordPress.DB.PreparedSQL.NotPrepared)
  916 | ERROR | Use placeholders and $wpdb->prepare(); found ? (WordPress.DB.PreparedSQL.NotPrepared)
  916 | ERROR | Use placeholders and $wpdb->prepare(); found : (WordPress.DB.PreparedSQL.NotPrepared)
  924 | ERROR | Use placeholders and $wpdb->prepare(); found $query (WordPress.DB.PreparedSQL.NotPrepared)
 1054 | ERROR | date() is affected by runtime timezone changes which can cause date/time to be incorrectly displayed. Use gmdate() instead.
      |       | (WordPress.DateTime.RestrictedFunctions.date_date)
 1055 | ERROR | date() is affected by runtime timezone changes which can cause date/time to be incorrectly displayed. Use gmdate() instead.
      |       | (WordPress.DateTime.RestrictedFunctions.date_date)
 1127 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
      |       | 'get_permalink'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
 1127 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
      |       | 'sanitize_text_field'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
 1130 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '_n'.
      |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 1130 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
      |       | 'number_format_i18n'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
 1132 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '_n'.
      |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 1132 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
      |       | 'number_format_i18n'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
 1134 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '_n'.
      |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 1134 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
      |       | 'number_format_i18n'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
 1134 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '_n'.
      |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 1134 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
      |       | 'number_format_i18n'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
 1136 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
      |       | 'get_permalink'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
 1136 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
      |       | 'get_edit_post_link'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
 1160 | ERROR | Processing form data without nonce verification. (WordPress.Security.NonceVerification.Missing)
 1161 | ERROR | Processing form data without nonce verification. (WordPress.Security.NonceVerification.Missing)
 1174 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $prefix at "SHOW TABLES LIKE '{$prefix}summary'"
      |       | (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
 1175 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $prefix at "TRUNCATE TABLE {$prefix}summary;"
      |       | (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
 1183 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $prefix at "SHOW TABLES LIKE '{$prefix}data'"
      |       | (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
 1183 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $prefix at "SHOW TABLES LIKE '{$prefix}summary'"
      |       | (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
 1184 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $prefix at "TRUNCATE TABLE {$prefix}data;"
      |       | (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
 1185 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $prefix at "TRUNCATE TABLE {$prefix}summary;"
      |       | (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
 1233 | ERROR | Processing form data without nonce verification. (WordPress.Security.NonceVerification.Missing)
 1373 | ERROR | Use placeholders and $wpdb->prepare(); found Helper (WordPress.DB.PreparedSQL.NotPrepared)
 1373 | ERROR | Use placeholders and $wpdb->prepare(); found :: (WordPress.DB.PreparedSQL.NotPrepared)
 1373 | ERROR | Use placeholders and $wpdb->prepare(); found curdate (WordPress.DB.PreparedSQL.NotPrepared)
 1373 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $this at "', INTERVAL {$this->config['tools']['log']['expires_after']}
      |       | DAY);" (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
 1406 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '__'.
      |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
 1428 | ERROR | Processing form data without nonce verification. (WordPress.Security.NonceVerification.Missing)
-------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: Users/myusername/workspace/vagrant-local/www/mywebsite-wp/public_html/wp-content/plugins/wordpress-popular-posts/src/Output.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------
 144 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
     |       | (WordPress.Security.EscapeOutput.OutputNotEscaped)
-------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: Users/myusername/workspace/vagrant-local/www/mywebsite-wp/public_html/wp-content/plugins/wordpress-popular-posts/src/Helper.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------
 165 | ERROR | date() is affected by runtime timezone changes which can cause date/time to be incorrectly displayed. Use gmdate() instead.
     |       | (WordPress.DateTime.RestrictedFunctions.date_date)
-------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: Users/myusername/workspace/vagrant-local/www/mywebsite-wp/public_html/wp-content/plugins/wordpress-popular-posts/src/Query.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
 467 | ERROR | Use placeholders and $wpdb->prepare(); found $where (WordPress.DB.PreparedSQL.NotPrepared)
 498 | ERROR | Use placeholders and $wpdb->prepare(); found $this (WordPress.DB.PreparedSQL.NotPrepared)
 498 | ERROR | Use placeholders and $wpdb->prepare(); found query (WordPress.DB.PreparedSQL.NotPrepared)
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: Users/myusername/workspace/vagrant-local/www/mywebsite-wp/public_html/wp-content/plugins/wordpress-popular-posts/src/Front/Front.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 6 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------------
 189 | ERROR | Detected usage of a possibly undefined superglobal array index: $_POST['token']. Use isset() or empty() to check the index exists before
     |       | using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated)
 189 | ERROR | Detected usage of a possibly undefined superglobal array index: $_POST['wpp_id']. Use isset() or empty() to check the index exists before
     |       | using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated)
 193 | ERROR | Detected usage of a possibly undefined superglobal array index: $_POST['token']. Use isset() or empty() to check the index exists before
     |       | using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated)
 194 | ERROR | Detected usage of a possibly undefined superglobal array index: $_POST['wpp_id']. Use isset() or empty() to check the index exists before
     |       | using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated)
 203 | ERROR | All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found
     |       | '$exec_time'. (WordPress.Security.EscapeOutput.OutputNotEscaped)
 243 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $table at "INSERT INTO {$table}data
     |       |  (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
 256 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $table at "INSERT INTO {$table}summary
     |       |  (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
-------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: Users/myusername/workspace/vagrant-local/www/mywebsite-wp/public_html/wp-content/plugins/wordpress-popular-posts/src/template-tags.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------------
  56 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $table_name at "SELECT pageviews FROM {$table_name}data WHERE postid =
     |       | %d;" (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
 137 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $views_time_range at "SELECT SUM(pageviews) AS pageviews FROM
     |       | {$wpdb->prefix}popularpostssummary WHERE {$views_time_range} AND postid = %d;" (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
 142 | ERROR | Use placeholders and $wpdb->prepare(); found $query (WordPress.DB.PreparedSQL.NotPrepared)
-------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: Users/myusername/workspace/vagrant-local/www/mywebsite-wp/public_html/wp-content/plugins/wordpress-popular-posts/src/Rest/ThumbnailsEndpoint.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------
 39 | ERROR | Intermediate images do not exist on the VIP platform, and thus get_intermediate_image_sizes() returns an empty array() on the platform. This
    |       | behavior is intentional to prevent WordPress from generating multiple thumbnails when images are uploaded.
    |       | (WordPressVIPMinimum.Functions.RestrictedFunctions.get_intermediate_image_sizes_get_intermediate_image_sizes)
-------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: Users/myusername/workspace/vagrant-local/www/mywebsite-wp/public_html/wp-content/plugins/wordpress-popular-posts/src/Rest/ViewLoggerEndpoint.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------------
 142 | ERROR | date() is affected by runtime timezone changes which can cause date/time to be incorrectly displayed. Use gmdate() instead.
     |       | (WordPress.DateTime.RestrictedFunctions.date_date)
 143 | ERROR | date() is affected by runtime timezone changes which can cause date/time to be incorrectly displayed. Use gmdate() instead.
     |       | (WordPress.DateTime.RestrictedFunctions.date_date)
 164 | ERROR | Use placeholders and $wpdb->prepare(); found $query_data (WordPress.DB.PreparedSQL.NotPrepared)
 165 | ERROR | Use placeholders and $wpdb->prepare(); found $query_summary (WordPress.DB.PreparedSQL.NotPrepared)
 174 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $table at "INSERT INTO {$table}data
     |       |  (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
 187 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $table at "INSERT INTO {$table}summary
     |       |  (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
-------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: Users/myusername/workspace/vagrant-local/www/mywebsite-wp/public_html/wp-content/plugins/wordpress-popular-posts/src/Image.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------------
 476 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $id at "SELECT post_content FROM {$wpdb->posts} WHERE ID = {$id};"
     |       | (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
 553 | ERROR | Use placeholders and $wpdb->prepare(); found interpolated variable $id at "SELECT post_content FROM {$wpdb->posts} WHERE ID = {$id};"
     |       | (WordPress.DB.PreparedSQL.InterpolatedNotPrepared)
 642 | ERROR | Detected high remote request timeout. timeout is set to 5. (WordPressVIPMinimum.Performance.RemoteRequestTimeout.timeout_timeout)
 670 | ERROR | Filesystem writes are forbidden, please do not use chmod(). (WordPressVIPMinimum.Functions.RestrictedFunctions.chmod_chmod)
 873 | ERROR | Intermediate images do not exist on the VIP platform, and thus get_intermediate_image_sizes() returns an empty array() on the platform. This
     |       | behavior is intentional to prevent WordPress from generating multiple thumbnails when images are uploaded.
     |       | (WordPressVIPMinimum.Functions.RestrictedFunctions.get_intermediate_image_sizes_get_intermediate_image_sizes)
-------------------------------------------------------------------------------------------------------------------------------------------------------------

Time: 6.05 secs; Memory: 28MB
Viewing 9 replies - 1 through 9 (of 9 total)
  • Plugin Author Hector Cabrera

    (@hcabrera)

    Hi @spinksys,

    Thanks for the report. PHPCS compliance is planned for a future release, no ETA on that though.

    With that being said, all those are notifications of PHPCS coding standards violations, not actual PHP fatal errors. You should be able to update the plugin regardless.

    Thread Starter spinksys

    (@spinksys)

    Hi Hector – thanks for the reply! Our hosting is through WordPress VIP, and these fixes are required for updating. Is the code open source? I’ve been making the fixes for the past few updates, I can easily make most of them and submit to you for review if you’d like.

    Plugin Author Hector Cabrera

    (@hcabrera)

    All of the WordPress plugins and themes out there are, by nature, open source – except for the paid ones, of course ?? The ones hosted here on www.ads-software.com use an SVN repository even.

    Personally I only use the SVN repo for new releases, all the actual development work happens on WordPress Popular Posts’ Github repository so feel free to send a PR (or multiple PRs if/when needed) and I’ll review when I get the time. Do please keep in mind that:

    1. some of these errors can be safely ignored via phpcs:ignore (eg. the WordPress.DB.PreparedSQL.Interpolated error messages coming from uninstall.php) so make sure to use that where/when it makes sense
    2. if you have specific questions / comments I’m more than happy to talk about it so feel free to reach out / let me know
    3. I don’t have PHPCS/WPCS set up on my machine, may need some guidance with that (but I’ll try to do my own research soon)
    Thread Starter spinksys

    (@spinksys)

    I’ll see what I can do in my off time – hopefully you can take a look as well.

    Thanks.

    Plugin Author Hector Cabrera

    (@hcabrera)

    Yeah, I may actually spend some time working on PHPCS compliance this upcoming weekend if time & family allow it.

    Plugin Author Hector Cabrera

    (@hcabrera)

    Hey there, just a quick update: I managed to set up PHPCS/WPCS on my PC. Everything is up and running nicely.

    At first glance the vast majority of the issues reported by phpcs (if not all of them) are easily fixable. I’m not 100% sure if all this will solve the problem you’re having with WordPress VIP not allowing you to update the plugin though, I guess we’ll find out soon once I have gone through all of them.

    Thread Starter spinksys

    (@spinksys)

    Agreed, most are easily fixable. Thanks for taking a look!

    Plugin Author Hector Cabrera

    (@hcabrera)

    Don’t mention it. Thank you for reminding me that I had that on my to-do list.

    I actually progressed a bit with this over the weekend and plan to continue over the next few days. Not sure when I’ll finish though but hopefully soon.

    Plugin Author Hector Cabrera

    (@hcabrera)

    Hey there!

    Took quite some time but version 6.1.2 is out and includes a bunch of PHPCS/WPCS fixes. Not sure if it’ll fix all of the issues reported by WordPress VIP though but hopefully should make your life easier.

    If you have any comments / questions please feel free to let me know.

Viewing 9 replies - 1 through 9 (of 9 total)
  • The topic ‘PHPCS errors preventing plugin update’ is closed to new replies.