Query parameter added after searching not working

Hi,

Can you please give me a link to your site search page so I can test it by myself?

Regards

Yes we haven’t launched yet so our site it is in coming soon mode but I can turn it off on our staging environment so you can test. There are only few test products but you can test with for example the brand “Saks pots” or “Ganni”.

https://visteyristg.wpengine.com/

Thanks. So I can search for some brands there but it looks like search results pages are disabled. Can you please enable it?

Regards

We have opened up for our live site so you can test there: https://visteyri.is

What do you mean by the search results pages are disabled? Where do I enable it?

Please forget about the search page – I just misunderstood you the first time.

So if you open the site admin page and go to products -> YOUR CUSTOM TAXONOMY NAME page, choose one of taxonomies and click View – what URL of the page do you see where this taxonomy will be opened?

There is no option to view it…
See screenshot: https://jmp.sh/l1ZIB29b

But the taxanomy name is merki and the slug for one of the “merki” (e. brand) is: ganni.

If I edit the brand the url is: https://visteyri.is/wp-admin/term.php?taxonomy=merki&tag_ID=815&post_type=product&wp_http_referer=%2Fwp-admin%2Fedit-tags.php%3Ftaxonomy%3Dmerki%26post_type%3Dproduct%26s%3Dganni

If I open all of the products of that brand within the admin console the url is: https://visteyri.is/wp-admin/edit.php?merki=ganni&post_type=product

In this case please tell me – how do you create these brands? Are you using any plugin or maybe custom code for this?

Hi,

We used custom code, like this:

  $brand_labels = [
    "name" => _x("Merki", "taxonomy general name"),
    "singular_name" => _x("Merki", "taxonomy singular name"),
    "search_items" => __("Merki"),
    "all_items" => __("Merki"),
    "parent_item" => __("Parent Merki"),
    "parent_item_colon" => __("Parent Merki:"),
    "edit_item" => __("Edit Merki"),
    "update_item" => __("Update Merki"),
    "add_new_item" => __("Add New Merki"),
    "new_item_name" => __("New Merki Name"),
    "menu_name" => __("Merki"),
  ];

  // Now register the non-hierarchical taxonomy like tag
  register_taxonomy("merki", "product", [
    "hierarchical" => true,
    "labels" => $brand_labels,
    "show_ui" => true,
    "public" => false,
    "publicly_queryable" => false,
    "show_in_rest" => true,
    "show_admin_column" => false,
    "query_var" => true,
    "rewrite" => ["slug" => "merki"],
  ]);
}

Do you notice anything missing that might be the cause?

I see that these brands are not publicly available. Did you do it on purpose or was it just a mistake??

You can change the line

 "public" => false,

to

 "public" => true,

After this you must see its URL inside the admin page and perhaps this will fix an issue with links inside search results.

Regards

It must have been a mistake, this code was added by someone else than myself so I’m not sure why it was set to false.

It did not work to change “public” to true but after I changed “publicly_queryable” to true as well the view option appeared and it links to:

https://visteyri.is/merki/ganni/

However, the URL doesn’t work. The page shows all products, not filtered by the “merki” (e. brand) Ganni.

So it is a link that I see from the admin area for your brand taxonomy. Is that correct? If so then it looks like the issue is not in the searching plugin but more common and related to your site and custom taxonomy that is created for it.

I think can can set to true both publicly_queryable and public parameters.

Also please try to remove

 "rewrite" => ["slug" => "merki"],

After this go to the WP admin dashboard -> Settings -> Permalinks page and click Save Changes button to reload permalinks structure.

I managed to fix it.

We also have the plugin Ajax Product Filters by BeRocket.

I changed the premalink structure so that it matches the pattern for the filters, then the search works when you click on custom taxonomy.

Thank you so much for the help!

Glad that your problem was solved successfully.

Hi again,

We just realised it broke our blog page. Now the “filters” parameter is in front of the url for blog posts as well.

Is there a way to adjust the URLs of custom taxonomies in the search so the results links to …/filters/custom-taxamony/value (such as /filters/brand/nike) but make sure the filters parameter is not added in front of our blog posts?

You can test on our site https://visteyri.is

If you click on the “blog” link in the footer and select a blog post you can see that the /filters/ is added in front of the URL causing us not to be able to access the blog posts.

But if we take the settings out of our premalink structure the search doesn’t work. Then the brand nike links to https://visteyri.is/merki/nike which doesn’t work, instead of https://visteyri.is/filters/merki/nike which works (merki means brand in Icelandic)