• Resolved fartbrat

    (@fartbrat)


    Currently, not only my permalinks aren’t fixed on the product catalog but my shortcode buttons are gone as well.

    What happen guys? It’s getting worse. My website needs the category to function.

    The page I need help with: [log in to see the link]

Viewing 7 replies - 1 through 7 (of 7 total)
  • Thread Starter fartbrat

    (@fartbrat)

    I rolled the theme back to blocksy 1.9.4 (two versions before)

    As you can see, this is what my category supposed to be.

    The button shows, so does the normal permalinks. Even the problematic link from iHerb (deep green) which has non.com link is accessible.

    Will Blocksy theme consider revert the theme?

    Hello @fartbrat

    What you were experiencing was actually incorrect. We had an issue in the previous versions that was rendering the excerpts incorrectly. So naturally, we had to address it according to the WordPress developer guidelines. That’s how WordPress-related things work like, with each update bugs are fixed and new guidelines are introduced.

    So, with 1.9.6, since you have requested it, we have introduced a filter that returns the old “broken” behaviour, if needed. Once you integrate it you will see that it will work as it was before.

    Hope this clears things up!

    Thanks.

    Thread Starter fartbrat

    (@fartbrat)

    Does 1.9.6 work on your end where the links show properly as they were in 1.9.4? Because it sure doesn’t work for me. Links are still missing, in fact, 1.9.5 at least shows my shortcode buttons and latest version show neither.

    I’m currently using 1.9.4 in which everything works as intended, even the external link broken by 1.9.5. I can upgrade to 1.9.6 again, and provide you with a screenshot, if needed, but i don’t think my website can keep running with it as no links will show.

    I tried my best to explain my case. If this is your best solution, which to me is a downgrade. It’s ok. I’ll just stick with 1.9.4, the theme i signed up for, until i find another theme.

    “Once you integrate it you will see that it will work as it was before.” – it doesn’t

    Thank you.

    Hello @fartbrat

    I’m sorry, but you’re really taking this the wrong way. It seems that you aren’t willing to understand how the system works, when I have explained to you that the behaviour from before was actually the broken one. And have also offered a solution to make it return to the broken behaviour.

    Excerpts should never include more than simple text in them. This is how the WordPress system works like, not how Blocksy in particular does. This is valid for any default theme. And again, I cannot speak for other themes. They are free to follow whatever guidelines they might want and choose to comply or not comply with the official ones. That’s their problem.

    Are you 200% sure that you have integrated that snippet correctly? I just verified this on your exact setup and I can say that it works perfectly. Here is definitive proof of that – https://streamable.com/a5jdk0.

    Hope this makes more sense now. ??

    Thank you.

    Theme Author creativethemeshq

    (@creativethemeshq)

    Hello @fartbrat,

    Like my colleague already mentioned, the fact that you saw links and other elements inside the excerpt in 1.9.4 was not correct.

    In 1.9.4 we made some changes and fixed a different problem and as a result the markup generated by the excerpt was wrong and also had some other issues (that most likely you didn’t noticed). In 1.9.5 we fixed those issues and excerpt started to work like it was working all the time (with no links inside).

    If you will revert back to 1.9.3 or any other version older than that you will see that the links won’t show also, and that’s the correct flow for an excerpt.

    An excerpt is just simple text and should not contain any other HTML elements like buttons, images and so on.

    But, we decided to help you with this and created a special PHP filter, and if you will implement it you will be able to see the links and other HTML elements inside the excerpt.

    Simply add this snippet and everything will be like you wish:

    add_filter(
    	'blocksy:excerpt:output',
    	function ($excerpt) {
    		global $post;
    
    		if (get_post_type($post) === 'product') {
    			return $post->post_excerpt;
    		}
    
    		return $excerpt;
    	}
    );

    Hope this helps.

    Thread Starter fartbrat

    (@fartbrat)

    @creativethemeshq I’ve added the code. It works now. Thank you!!!!

    Theme Author creativethemeshq

    (@creativethemeshq)

    Hi @fartbrat, that’s awesome!

    Have a wonderful week ??

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘Shortcode buttons disappear and external links still not showing after update’ is closed to new replies.