Fatal Error in Debug Mode

  • Resolved typeless

    (@jbalyo)


    1 year, 2 months ago

    The latest published version of Document Gallery (4.4.3) produces a Fatal Error whenever WordPress is in Debug mode. I tracked this down to a misuse of the implode function here:

    /inc/class-gallery.php – Line 542:

    $comment .= '<!-- Attachment IDs: ' . implode( $ids, ', ' ) . ' -->' . PHP_EOL;

    PHP documentation states that implode() takes a separator and an array, in that order. So the above should be:

    $comment .= '<!-- Attachment IDs: ' . implode( ', ', $ids ) . ' -->' . PHP_EOL;

    EDIT: I see this bug was fixed in 4.4.4 – but this version is only in the repository – not yet published. Is this version still in development? When can we hope to see it pushed live?

    • This topic was modified 1 year, 2 months ago by typeless.
Viewing 1 replies (of 1 total)
  • Plugin Author Dan Rossiter

    (@danrossiter)

    Hi @jbalyo –

    Apologies for the delayed response! My email notifications were not working how I expected them to and never saw this post ??

    Yes, 4.4.4 fixed this. Unfortunately, I made an oopsie when publishing that version and it never made it out to the public until about 10m ago. Should be available now – apologies for the inconvenience!

    -Dan

Viewing 1 replies (of 1 total)
  • The topic ‘Fatal Error in Debug Mode’ is closed to new replies.