[Plugin: Ultimate Taxonomy Manager] PHP Notices

See my other post. You MUST turn on PHP notices while developing, otherwise you won’t be able to tell when you’re writing bad code. And when someone tries to use this plugin on a server that is displaying PHP notices, they get notices popping up everywhere in the wp manager.

Your code looks pretty good and pretty clean — nice job. The biggest thing you have to fix is when you read variables out of the $_GET array.

E.g. this will throw a notice if your URL doesn’t have a ‘myvar’ parameter:

if ( $_GET['myvar'] == 'something' )
{
 // ... do something
}

Instead, you should spend the extra time to check whether or not the place in the array is set:

if ( isset($_GET['myvar']) && $_GET['myvar'] == 'something' )
{
  // ... do something
}