This turned out to be harder to fix than I expected.
The proposed change from the github issue doesn’t fix the issue as the check on line 38 is outside the init action and REST_REQUEST is probably not defined yet.
Also, I don’t think the ‘edit’ context will ever be true when saving a draft or updating a post. I did spot ‘view’ and ‘edit’ contexts when refreshing the editor and while editing though.
I then tried checking for only REST_REQUEST but that also failed when checked too early. It seems to fail even if checking right before ob_start(‘teckel_minify_html_output’).
It follows that the REST check needs to happen as late as possible.
So I did some logging to find out how many times the minify function runs and without any changes it looks like the minify function can run up to 10 times when refreshing the editor and 3-5 times when saving a post. Didn’t test without Yoast so that might contribute.
I then made a helper function that can be run in the init hook (to avoid buffering unnecessarily) and also again in the output buffer callback (to avoid minifying and when we do, only do it once):
function teckel_should_skip_minifying() {
/* Bail if CLI */
if ( defined( 'WP_CLI' ) && WP_CLI ) {
error_log( 'BAIL - WP_CLI true' );
return true;
}
/* Bail if admin pages */
if ( is_admin() ) {
error_log( 'BAIL - is_admin() true' );
return true;
}
/* Bail if REST REQUEST */
if ( defined( 'REST_REQUEST' ) && REST_REQUEST ) {
error_log( 'BAIL - REST request' );
return true;
}
/* Bail if any context */
if ( isset( $_GET['context'] ) ) {
error_log( 'BAIL - context set to ' . $_GET['context'] );
return true;
}
/* Nothing stopping us from minifying */
error_log( 'teckel_should_skip_minifying() - return false' );
return false;
}
I then call this helper function like this:
function teckel_init_minify_html() {
if ( teckel_should_skip_minifying() ) {
return;
}
...
and:
function teckel_minify_html_output($buffer) {
if ( teckel_should_skip_minifying() ) {
return $buffer;
}
...
Notably even now, just refreshing the editor, I still see in the logs that the plugin minifies at least once. This could be Yoast or something else doing something with the content. But at least the content is not converted to a classic block anymore.
All of those checks need to be separate or this doesn’t work. You will find all conditions printing something in the logs multiple times by just refreshing the editor.
I wish there was a cleaner fix but this finally seems to work. Let me know if you find a cleaner way.
