Post Carousel bug + solution

  • Resolved Jory Hogeveen

    (@keraweb)


    12 months ago

    There is a bug in the Post Carousel frontend.js.php file.
    Then there is no setting available for move_slides it will currently render nothing:

    moveSlides: <?php echo $settings->move_slides; ?>,

    This will result in JS code that creates a fatal error “Unexpected ‘,'” since there is no value for modeSliders.:

    moveSlides:,onSlideBefore: etc.

    Simple solution would be to cast it to an integer:

    moveSlides: <?php echo <span style="font-family: inherit; font-size: 0.8rem;">(int) $settings->move_slides; </span><strong style="font-family: inherit; font-size: 0.8rem;">?><span style="font-family: inherit; font-size: 0.8rem;">,</span>

    This is most likely the case with more settings throughout the codebase.
    I couldn’t find a repo on GitHub for this so therefore I posted it here.

    Cheers, Jory

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Contributor Jamie

    (@codente)

    Hi Jory,

    Thanks for reporting this. I’ve filed a bug report for our development team and we’ll get this fixed up!

    Thread Starter Jory Hogeveen

    (@keraweb)

    Hi @codente

    Thanks for your quick reply.

    Upon reading my own post again I noticed that the editor messed up my code a bit.
    The fixed code should be:

    moveSlides: <?php echo (int) $settings->move_slides; ?>,

    Cheers, Jory

    Plugin Contributor Jamie

    (@codente)

    No worries, we got it! And thanks again! It will be in the next BB release (2.7.4). I expect that within the next 2 weeks.

    • This reply was modified 12 months ago by Jamie.
Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Post Carousel bug + solution’ is closed to new replies.