OMGF breaks WooCommerce 8.5.1

  • Resolved jackennils

    (@jackennilsen)


    10 months, 1 week ago

    Hello there!

    When updating WooCommerce to 8.5.1, OMGF is breaking the functionality of adding items to the cart. I can select a product or variation and add it to the cart, but the cart stays empty. Even though I get the message that the product was added to the cart. When I deactivate OMGF everything is back to normal.

    Please can someone help? I cannot show a live example as I have (thankfully) only updated my staging environment until now. But if there is any chance of sending login credentials, you can take a look for yourself.

    Here’s a screen capture:
    https://lumiqy.de/OMGF_WC8.5.1_issue_20240117.mp4

    Thanks
    Marco

Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Author DaanvandenBergh

    (@daanvandenbergh)

    It works on my test environment, so it must be something related to your theme or another plugin? Any other updates you made recently?

    In your video I noticed you have a staging environment. Could you try switching to the Storefront theme and disable all other plugins? If it starts working then, enable plugins one by one to see if you can find the culprit. If that doesn’t work. Disable all plugins again, switch to the theme you’re currently using and see if it breaks. If it doesn’t, it might be a combination of your theme with another plugin, so start enabling all plugins again one by one, and now you should find the culprit.

    Let me know once you find the culprit, so I can see what I can do about compatibility!

    Thread Starter jackennils

    (@jackennilsen)

    Hello Daan,

    Thanks for the quick reply. The update of WC from 8.4 to 8.5.1. was the only update.

    I did try your suggestion and the issue still occurs using Storefront with only WC and OMGF activated.

    Kind regards
    Marco

    @jackennilsen All other plugins are still active, so it’s not clear what exactly breaks, especially if there’s any page optimisation or page caching involved.

    Take a look at your error_log and wp-admin/error_log files, as well as the browser console, and share what you see that seems relevant.

    Also, WooCommerce 8.5.1 seems to have A LOT of support threads, so check those and see if any are relevant to your situation. If so, just wait for the next release. Plugins updates aren’t generally urgent, unless they resolve a problem you’re having or plugging some widespread security hole.

    Thread Starter jackennils

    (@jackennilsen)

    No, I wrote that all plugins have been disabled except for WC and OMGF.

    The debug log shows this error when OMGF is active:

    `[19-Jan-2024 16:03:01 UTC] PHP Fatal error: Uncaught TypeError: array_keys(): Argument #1 ($array) must be of type array, bool given in /www/htdocs/w01a4bb6/web/staging-lumiqy2/wp-content/plugins/host-webfonts-local/src/Helper.php:220
    Stack trace: 0 /www/htdocs/w01a4bb6/web/staging-lumiqy2/wp-content/plugins/host-webfonts-local/src/Helper.php(220): array_keys(false) 1 /www/htdocs/w01a4bb6/web/staging-lumiqy2/wp-content/plugins/host-webfonts-local/src/Helper.php(184): OMGF\Helper::cache_keys() 2 /www/htdocs/w01a4bb6/web/staging-lumiqy2/wp-content/plugins/host-webfonts-local/src/Frontend/Process.php(613): OMGF\Helper::get_cache_key(‘xts-google-font…’) 3 /www/htdocs/w01a4bb6/web/staging-lumiqy2/wp-content/plugins/host-webfonts-local/src/Frontend/Process.php(391): OMGF\Frontend\Process->build_search_replace(Array) 4 /www/htdocs/w01a4bb6/web/staging-lumiqy2/wp-includes/class-wp-hook.php(324): OMGF\Frontend\Process->parse(‘…’) 5 /www/htdocs/w01a4bb6/web/staging-lumiqy2/wp-includes/plugin.php(205): WP_Hook->apply_filters(‘…’, Array) 6 /www/htdocs/w01a4bb6/web/staging-lumiqy2/wp-content/plugins/host-webfonts-local/src/Frontend/Process.php(298): apply_filters(‘omgf_buffer_out…’, ‘…’) 7 [internal function]: OMGF\Frontend\Process->return_buffer(‘…’, 9) 8 /www/htdocs/w01a4bb6/web/staging-lumiqy2/wp-includes/functions.php(5373): ob_end_flush() 9 /www/htdocs/w01a4bb6/web/staging-lumiqy2/wp-includes/class-wp-hook.php(324): wp_ob_end_flush_all(”) 10 /www/htdocs/w01a4bb6/web/staging-lumiqy2/wp-includes/class-wp-hook.php(348): WP_Hook->apply_filters(NULL, Array) 11 /www/htdocs/w01a4bb6/web/staging-lumiqy2/wp-includes/plugin.php(517): WP_Hook->do_action(Array) 12 /www/htdocs/w01a4bb6/web/staging-lumiqy2/wp-includes/load.php(1260): do_action(‘shutdown’) 13 [internal function]: shutdown_action_hook() 14 {main}

    thrown in /www/htdocs/w01a4bb6/web/staging-lumiqy2/wp-content/plugins/host-webfonts-local/src/Helper.php on line 220′

    Yes it seems, WC 8.5.1 is a total mess. I hope it’s a problem on their side and they’ll fix it soon.

    • This reply was modified 10 months, 1 week ago by jackennils.

    This seems to be an OMGF error, unrelated to WooCommerce. To confirm, you can deactivate WooCommerce and check again.

    Is your staging site on a public address, i.e. it can download Google fonts?

    Also, it seems you’re not using the latest version of OMGF, because the only array_keys() in src/Helper.php on the latest version is on like 220, not 184. Please confirm whether this issue is still present with the latest version of OMGF (v5.7.13).

    Thread Starter jackennils

    (@jackennilsen)

    As you can see in the video which I have added in the first post, I am on 5.7.13.

    I think I have found the issue. After cloning the live site for the staging environment, I had to empty the OMGF cache so that fonts are downloaded again. Now it works again. ??

    Plugin Author DaanvandenBergh

    (@daanvandenbergh)

    Happy you managed to fix it. The code should’ve dealt with your minor error though. So, next release will include a fix to prevent this error.

    Thread Starter jackennils

    (@jackennilsen)

    Sounds good. Thanks for the help ??

Viewing 8 replies - 1 through 8 (of 8 total)
  • The topic ‘OMGF breaks WooCommerce 8.5.1’ is closed to new replies.