• Resolved Pieterjan Deneys

    (@nekojonez)


    I was explaining to a friend how their website worked and when I came to WordFence, we noticed something odd…

    https://ibb.co/58zkhzw

    The buttons for “Cancel changes” and “Save changes” look like they are broken. I’m using the nl_BE translations here and I have checked them over and over again and I don’t see a translation mistake.

    If I look via inspect element, I notice this:

    https://ibb.co/VL6vJrZ

    Is there something odd going on here?

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Support wfmargaret

    (@wfmargaret)

    Hi @nekojonez,

    Thanks for reaching out!? The translations for Wordfence are contributed by the community, so there may be minor inaccuracies.? In this case, as you saw, there is a hidden span that contains the word Changes in English. In the nl_BE translation the span tag should have been moved to the word “Wijzigingen” to ensure the correct word is hidden.? For example, the translation would need to be formatted something like this:

    <span class=”wfls-visible-sm-inline”>Wijzigingen </span>opslaan

    You can suggest an updated translation in https://translate.www.ads-software.com/projects/wp-plugins/wordfence/. You can find WordPress’s How to Translate guide at https://make.www.ads-software.com/polyglots/handbook/translating/how-to-translate/.

    Thanks,
    Margaret

    Thread Starter Pieterjan Deneys

    (@nekojonez)

    @wfmargaret I’d reconsider how the text is displayed on those buttons then. Since grammatically it doesn’t make sense then in Dutch if we would switch the words. It’s like saying: “He is playing with a ball red.”

    Besides that, I’d also add a translator comment since it’s important information to know while translating.

    Plugin Support wfmargaret

    (@wfmargaret)

    Hi @nekojonez,

    Thank you for following up and I’m sorry about any confusion here!  Please let me know if I’m misunderstanding, as Dutch isn’t a language I’m very familiar with.

    There should be no need to switch the word order from what’s grammatical in Dutch.  The span tag is what determines which word is hidden on those pages, so in the example I sent, you can see that grammatically it is still written as “Wijzigingen opslaan,” but the word Wijzigingen is hidden instead of opslaan.

    I do see that the translations were updated so that the buttons are now displaying as OPSLAAN and ANNULEREN with nl_BE.? If this isn’t the intended behavior, please let me know. There is also a translator note on the relevent strings mentioning that the word order can be reversed as long as the HTML remains around “Changes,” but please let me know if any are missing that comment.

    Thank you!
    Margaret

    Thread Starter Pieterjan Deneys

    (@nekojonez)

    As a GTE for nl_BE I updated them right away. ?? But, I think that the whole span tag should be something that shouldn’t be done for buttons. Since, it makes it confusing for users and translators in my honest opinion.

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Bug report: cancel and save not shown on buttons’ is closed to new replies.