Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Support Shubhanshu Kandani

    (@shubhanshukandani)

    Hi @itapress,

    Thank you for contacting us. We’re happy to support you.

    Regarding the mentioned function, we attempted to replicate it using the esc_html() function translation. Could you please provide us with more information to help us replicate the issue on our end? This will help us understand the problem better.

    We look forward to your response.

    Thread Starter itapress

    (@itapress)

    Hello @shubhanshukandani

    Thank you for the reply.

    As you surely already know, for strings that you want to make translatable (via the .pot file or via translate.www.ads-software.com) you do not use the esc_html() function but those other alternatives, such as esc_html__().

    However, if you do not want to make the string translatable, using the esc_html() function is correct, but in this case the text domain should not be added.

    Also, this string is also referred to as text domain ‘icegram_‘:

    https://plugins.trac.www.ads-software.com/browser/icegram/tags/3.1.23/lite/gallery.php#L766

    Thanks.

    Plugin Support Shubhanshu Kandani

    (@shubhanshukandani)

    Hi @itapress ,

    Thank you for sharing the information with us. We were able to replicate the issue and will fix it soon.

    Let me know if you need any additional support.

    Plugin Support Shubhanshu Kandani

    (@shubhanshukandani)

    Hi @itapress ,

    Thank you for your patience and support.

    We have released the fixed version of the plugin. Could you please update the plugin and check if the issue is resolved?

    Thread Starter itapress

    (@itapress)

    Hello @shubhanshukandani

    Thank you for the reply.

    I saw that in the new version 3.1.25 almost all the problems I reported have been resolved.

    However, I am sorry to have to point out that in this line of this file:

    https://plugins.trac.www.ads-software.com/browser/icegram/tags/3.1.25/lite/gallery.php#L766

    there are still the following problems:

    esc_html__('Filter out the templates based on %1s  and %2s and then simply','icegram_')

    (this string is referred to as text domain ‘icegram_‘ instead of ‘icegram‘, and I think it’s better to change %1s and %2s to %1$s and %2$s)

    '<strong>your goals</strong>', '<strong>message type</strong>'

    (these strings are hardcoded and are not translatable)

    Thanks.

    Plugin Support Shubhanshu Kandani

    (@shubhanshukandani)

    Hi @itapress ,

    Thanks for the confirmation on the previous report issue.

    We will release the fix for the above-mentioned issue in the upcoming release. Thank you for your support and for highlighting it.

    Let me know if you need any further assistance.

    Thanks!

Viewing 6 replies - 1 through 6 (of 6 total)
  • You must be logged in to reply to this topic.