Profile settings bug? (and interm fix)

  • Resolved Mandi

    (@mandifaux)


    7 months, 1 week ago

    Just updated a couple of my sites Youzify to the new version, and I went from 1.2.5 to 1.2.9, so I am not sure at what point something was removed. It causes a potential bug in the member settings area, none of the icons show up because the background defaults to white (#fff), and the alignment doesn’t place those icons in a row either. It looks like this:

    The html part that changed went from this:

    To this:

    The div classes for the individual buttons is no longer there. Still cannot find where that gets put in so I can put them back. The interm fix I did was this (it makes the buttons all one color, using the scheme, so they are no longer colorful like before but it does make them all align correctly and show up at least.

    .youzify-head-buttons .youzify-head-buttons-inner {
    display: inline-flex;
    }
    .youzify-head-buttons a {
    background: var(--yzfy-scheme-color) !important;
    }
    .youzify-head-buttons-inner > div {
      padding: 0px 4px !important;
    }

    Not sure what all themes are affected by this. This happened with Tentered and Obelisk that I know of so far. Just in case anyone else has this issue, that’s a temporary fix for it at least. The above goes into the customize > additional css area.

    • This topic was modified 7 months, 1 week ago by Mandi.
Viewing 6 replies - 1 through 6 (of 6 total)
  • Thread Starter Mandi

    (@mandifaux)

    I can and will do that. I do have another that is still on version 1.2.5, so I am going to download the other versions and update it one by one and see which one causes the change.

    This is the before, with red arrow showing what does change (the buttons on profile settings page)

    Will post the after, when I get to the version that takes the buttons div classes out for reference to when that happened. This is on latest WP 6.6.1 and latest version of Buddypress.

    Thread Starter Mandi

    (@mandifaux)

    The div claases for those buttons went missing on version 1.2.9, all other versions that area appeared normal. This is the after

    Thread Starter Mandi

    (@mandifaux)

    With my temporary css fix, it makes it look like this. Buttons no longer colorful, but at least the align up correctly and use the Youzify scheme color.

    Thread Starter Mandi

    (@mandifaux)

    I think I found the change that causes the div class to no longer appear. Something to do with this part of the changes, from 1.2.8 to 1.2.9

    Index: youzify/trunk/includes/public/core/class-youzify-account.php
    ===================================================================
    --- a/youzify/trunk/includes/public/core/class-youzify-account.php
    +++ b/youzify/trunk/includes/public/core/class-youzify-account.php
    @@ -613,5 +613,5 @@
                     <div class="youzify-head-buttons-inner">
                     <?php foreach ( $header_buttons as $key => $button ) :?>
    -                    <div class="youzify-button-item youzify-<?php echo $key; ?>-button" style="width: <?php echo 100 / $count; ?>%;"><a href="<?php echo $button['url'] ?>" data-youzify-tooltip="<?php echo $button['title']; ?>" ><i class="<?php echo $button['icon'] ?>"></i></a></div>
    +                    <div class="<?php esc_attr( 'youzify-button-item youzify-' . $key .'-button' ); ?>" style="width: <?php echo 100 / $count; ?>%;"><a href="<?php echo esc_url( $button['url'] ); ?>" data-youzify-tooltip="<?php echo esc_attr( $button['title'] ); ?>" ><i class="<?php echo esc_attr( $button['icon'] ); ?>"></i></a></div>
                     <?php endforeach;?>
                     </div>

    I added echo in front of esc_attr and that makes it work again as it was before. Like this:

    <div class="<?php echo esc_attr( 'youzify-button-item youzify-' . $key .'-button' ); ?>" style="width: <?php echo 100 / $count; ?>%;"><a href="<?php echo esc_url( $button['url'] ); ?>" data-youzify-tooltip="<?php echo esc_attr( $button['title'] ); ?>" ><i class="<?php echo esc_attr( $button['icon'] ); ?>"></i></a></div>
    Thread Starter Mandi

    (@mandifaux)

    No problem.

    The problem is solved on my end, but there is a definite bug with the 1.2.9 update in the above reference to that code change at line 615 on youzify/includes/public/core/class-youzify-account.php

    Others will have the issue too until its updated adding in echo after the esc_attr (without echo the div classes are blank)

    Thread Starter Mandi

    (@mandifaux)

    You’re welcome. Also thanks again for all the hard work putting Youzify together. ??

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Profile settings bug? (and interm fix)’ is closed to new replies.