• Resolved davidsjptimoney

    (@davidsjptimoney)


    Version 2.3.0 (free) appears to have a bug under certain conditions. When you press the Esc key to close the lightbox, the browser page freezes. You have to F5 to reload and unstick it. The X button on the lightbox (top-right) works fine. The problem appears to relate solely to the use of the Esc key.

    This initially happened on a development environment (so not publicly-accessible): Windows 11 Home 23H2; Wampserver 3.3.6 (Apache 2.4.51, PHP 7.4.26); WordPress 6.6.1 (twentytwentytwo theme 1.7). I’ve updated the plugin twice, rolling back in between, and the problem has occurred on each occasion.

    I have also updated our production environment: LiteSpeed (Apache 2.4.62, PHP 7.4.33); WordPress 6.6.1 (twentytwentytwo theme 1.7).

    UPDATE: The specific issue is that the page vertical scrollbar disappears after the use of the Esc key. Buttons on the page can still be clicked etc.

    Browser tests: Chrome 128.0.6613.85: fails on both dev & live instances; Microsoft Edge 128.0.2739.42 fails on dev but NOT on live.

    Both instances have a custom CSS directive to force the scroll bar on – body {overflow-y: scroll !important;} – but removing this does not change the behaviour.

Viewing 11 replies - 1 through 11 (of 11 total)
  • Plugin Author FirelightWP

    (@firelightwp)

    @davidsjptimoney – Thanks for the report. That’s obviously a serious issue. I’ll take a look at it shortly.

    Plugin Author FirelightWP

    (@firelightwp)

    @davidsjptimoney – I’m not able to duplicate this in any environment I try, but I have a hunch what’s causing it.

    Any chance you could reach out via firelightwp.com/contact? I’d provide you with a zip to try. If that zip fixes the issue on your side, then I’ll release that fix. I’d just like to confirm it works before pushing the change to everyone.

    Thread Starter davidsjptimoney

    (@davidsjptimoney)

    I’ve sent my contact details via firelightwp.com/contact

    Plugin Author FirelightWP

    (@firelightwp)

    I just released a fix for this in version 2.3.1.

    For context, 2.3.0 included a fix for an issue where web page backgrounds are still scrollable on IOS devices when the lightbox is open. That fix apparently created the issue reported here in different environments. This issue is more serious, so I’ve reverted the IOS fix and will return to that separately.

    Big thanks, @davidsjptimoney, for helping test/confirm this fix.

    Thread Starter davidsjptimoney

    (@davidsjptimoney)

    Fixed by release 2.3.1.

    The version 2.3.1 has created a severe error on my website – WordPress only grants access in recovery mode.
    The error message is:

    Fehler-Details
    ==============
    Ein Fehler vom Typ E_ERROR wurde in der Zeile 64 der Datei /www/htdocs/felbec/new/wp-content/plugins/easy-fancybox/inc/class-easyfancybox-admin.php verursacht. Fehlermeldung: Uncaught Error: Call to undefined method easyFancyBox_Advanced::has_valid_license() in /www/htdocs/felbec/new/wp-content/plugins/easy-fancybox/inc/class-easyfancybox-admin.php:64
    Stack trace:
    #0 /www/htdocs/felbec/new/wp-content/plugins/easy-fancybox/easy-fancybox.php(60): easyFancyBox_Admin->__construct()
    #1 /www/htdocs/felbec/new/wp-settings.php(522): include_once(‘/www/htdocs/fel…’)
    #2 /www/htdocs/felbec/new/wp-config.php(114): require_once(‘/www/htdocs/fel…’)
    #3 /www/htdocs/felbec/new/wp-load.php(50): require_once(‘/www/htdocs/fel…’)
    #4 /www/htdocs/felbec/new/wp-admin/admin.php(34): require_once(‘/www/htdocs/fel…’)
    #5 /www/htdocs/felbec/new/wp-admin/index.php(10): require_once(‘/www/htdocs/fel…’)
    #6 {main}
    ?thrown

    I needed to roll back to 2.2.10, my website is now working properly. (Roll back to 2.3.0 did not help)

    Plugin Author FirelightWP

    (@firelightwp)

    Hi @michaelacwp,

    1) Just to confirm, your post is unrelated to original post in this thread (ie, the the escape key not working)?

    2) For your error, are you by chance using an older version of Easy Fancybox Pro? I think that’s the only way that error would occur. I should have an appropriate check for that. I’ll work on a fix, but I’d also like to confirm I’m diagnosing the issue correctly.

    Hi @firelightwp

    1. Yes, sorry – my reply is unrelated to the original “escape key” post.
      I do not know how to repair/change this.
    2. Oh – yes, I have the Easy Fancybox Pro extension, version 1.8.1
      It’s activated.
      Do I still need it? Shall I try to deactivate?
      In the FirelightWP settings I find:
      – Easy Fancybox General Settings
      – Choose Lighbox Version –> FancyBox Legacy

    Any hints/tipps welcome.

    Plugin Author FirelightWP

    (@firelightwp)

    @michaelacwp – I just pushed a fix for this in version 2.3.2. Feel free to upgrade and confirm the issue is resolved.

    I needed to better check some methods for compatibility with older pro versions. That’s the main issue here. As a rule, I’m hyper attentive to compatibility and backwards compatibility issues, so I’m surprised and sorry I missed this.

    Thanks for the report. Glad to get it fixed quickly.

    Hi @firelightwp

    Great :-)))
    I updated to 2.3.2 and everything is fine now.
    G r e a t support. Thank you!

    Best regards.
    Michael

    Plugin Author FirelightWP

    (@firelightwp)

    Wonderful. Glad it is resolved. Sorry for the issue and thanks again for the report!

Viewing 11 replies - 1 through 11 (of 11 total)
  • You must be logged in to reply to this topic.