Welcome Email displaying only shortcode

Further note, now I can see that my initial message has somehow removed the three pairs of curly brackets around the texts I was seeing and turned them into a sort of box. I don’t understand why that has happened, but hope you will. In my emails I am seeing three curly brackets then usermessage then three closed curly brackets.

Hi, I am seeing the same issue.

All Group welcome emails sent out since Aug 22nd (when we updated) no have the subject of :

[Site Name] ges.subject

The email content is similar but all boiler plate format is there just no text other than:

usermessage

Similar issue to previous message, block editor is stripping the 3 curly braces surrounding the place holders above { and } .

Any pointers for investigating this?

I am running BPGES along with BubbyBoss and I understand there are issues with this config, but the welcome emails were working ok.

WP 6.6.2
BP Auto Group Join: 1.0.4
PHP : 8.0.30

thanks, Colin

• This reply was modified 2 months, 1 week ago by colinfroggatt.
• This reply was modified 2 months, 1 week ago by colinfroggatt.

sorry, mistake in my last message, this is of course

BuddyPress Group Email Subscription , not Group Auto Join.

version 4.2.3

Also, @revcoincidence , are you running just BuddyPress or maybe BubbyBoss? Some context of your setup would be helpful (WP, php, BP or BB). -C

• This reply was modified 2 months, 1 week ago by colinfroggatt.

I have done some digging.

/buddypress-group-email-subscription/bp-activity-subscription-functions.php

ass_send_welcome_email( $group_id, $user_id ) : 2645
The $args is built with the correct subject and content.

This calls ass_send_email( $email_type, $to, $args ): 1010
where the subject and content args are removed.

if ( true === function_exists( 'bp_send_email' ) && true === ! apply_filters( 'bp_email_use_wp_mail', false ) ) {
	// BP 2.5+

	// Unset array keys used for older BP installs.
	unset( $args['subject'], $args['content'] );
        .....

I don’t know BP or BPGES well enough to understand why you want to do this but it seems to be the place that breaks it for Welcome emails.

-C

So I reverted back to BPGES 4.2.2 and the welcome messages are working again.

I diff’ed bp-activity-subscription-functions.php between 4.2.2 and 4.2.3 and the only changes I could see in the above areas was the change in array syntax when building $args array at ass_send_welcome_email( $group_id, $user_id ) : 2645.

A closer look at the new code block that builds the $args reveals that the following elements in the tokens array have been missed out:
‘ges.subject’
‘usermessage’
‘group.link’

So in this case, the first two are breaking the Welcome message. No idea of impact of the third.

I have rolled back to 4.2.2 for the moment. We would appreciate a fix for this when you get the chance.

Thank you also for your continued effort in improving this plugin. It is appreciated ??

-C

Thanks @colinfroggatt for your comments.

I am using WP 6.2.2, php 8.2.24, Buddypress 14.1.0, and BPGES 4.2.3

Sadly, I can’t “roll back” to an earlier version because 4.2.3 is the first version I have installed.

I’m also not able to dig around in the code in the way you have (nor do I understand it), so I guess I’m stuck till it’s fixed. Unless you or anyone else has any other ideas?

Hi @revcoincidence . I use the term rollback loosely ?? You can down load previous versions of the plugin from the url below. It’s the ‘advanced’ page from the WP plugin page (all plugins have this). Go to the bottom of the page, click the dropdown that defaults ‘development version’ and choose your version to download.

Install from your sites “add new plugin” page. Hit the “upload plugin” in the top/left corner and choose the zip file you downloaded. It will update and ask you if you want to replace the current version – click yes.

https://www.ads-software.com/plugins/buddypress-group-email-subscription/advanced/

cheers, Colin

Thanks @colinfroggatt

That’s super helpful. I wondered whether there might be a way. Anyway – I am now better informed, have replaced the new plugin with the old and it all works! Just what I need.

And now we just need the next update to contain a fix for what 4.2.3 broke ??

Many thanks,
Mark

@revcoincidence Great, glad it helped. Might be telling you what you know, but don’t forget to turn off auto-update until it’s fixed. ??

cheers, Colin

I have raised an issue on the BPGES github repo: https://github.com/boonebgorges/buddypress-group-email-subscription/issues/250

Thanks @colinfroggatt

I had disabled the auto-update, but thank you for thinking of me. I also appreciate you pursuing this on github. (I wouldn’t have known about that possibility!)

@revcoincidence . Boone has release v4.2.4 which fixes the issues.

C.