fullscreen section issue

  • after update new version follow issue:

    class=”home page-template-default page page-id-2 logged-in admin-bar no-customize-support body-header-style3 body-fullscreen-sections body-fullscreen-first-section-colored”

Viewing 11 replies - 1 through 11 (of 11 total)
  • Plugin Author TobiasBg

    (@tobiasbg)

    Hi!

    Thanks for your post and sorry for the trouble!

    Can you please provide more details here? What exactly is broken? The CSS class that you posted here seems to be coming from the <body> HTML tag on your page — but it doesn’t have anything from TablePress in it?

    Best wishes,
    Tobias

    Thread Starter spielo

    (@spielo)

    Hi,

    if i put a tablepress shortcode in the Full width sections in my editor, then i get the massage in the top of my website, ok is only for admin or logged in users to see. but it is since the version 3.0. at the moment i rollback and all works fine

    regards

    Plugin Author TobiasBg

    (@tobiasbg)

    Hi!

    Thanks for your post and sorry for the trouble!

    Can you please clarify? What message are you getting?

    To find out what’s wrong here, I would need to take a look at the page. For that, please update to TablePress 3.0 again and please post a link to the page with the table where this problem happens, so that I can take a direct look. Thanks! Otherwise I can not fix this problem on your site, sorry ??

    Best wishes,
    Tobias

    Thread Starter spielo

    (@spielo)

    Hi,

    Thanks for your feedback, but we’ve also noticed that the complete CSS we had implemented is no longer working, which basically means the entire plugin has likely been updated. Unfortunately, we’ll never understand why developers make such changes when everything was running perfectly fine! Anyway, we’ve now reverted to the old version and will keep it running until it no longer works, or until you reach version 5.0, which we’ve now assigned to the plugin. Still, thanks for wanting to investigate it, but at the moment, it doesn’t make sense for us since we’d have to change everything.

    Plugin Author TobiasBg

    (@tobiasbg)

    Hi,

    but this is what I tried explaining above! ?? The changes were not made by choice, but are a consequence of having to update an external library. And the changes that were made there are actually good, because they make tables much more accessible for users with disabilities or users of assistive technologies. (This is even required by law, in some countries!)

    I understand that you are afraid of having to update the CSS code, but this really should be straightforward. If you want, you can also send me the link to your current CSS file and I will tell you what to do. You could then of course simply try this on a test or staging site first.

    Best wishes,
    Tobias

    Thread Starter spielo

    (@spielo)

    can i send you link and login for staging site private?

    Plugin Author TobiasBg

    (@tobiasbg)

    Hi,

    please use the green “Send us an email!” button at the bottom of?https://tablepress.org/pricing/?and I’ll see what we can do.

    Best wishes,
    Tobias

    Thread Starter spielo

    (@spielo)

    done, send you mail

    thanks

    Plugin Author TobiasBg

    (@tobiasbg)

    Hi,

    Thanks! I will take a look as soon as time permits!

    Best wishes,
    Tobias

    Thread Starter spielo

    (@spielo)

    hi Tobias, i find out the issue comes from this code in controller-frontend.php, if i use the the code from 2.4 version it works well, no header issue and also customer css works well

    public function enqueue_css(): void {
    /*
     * Bail early if the function is called from some action hook outside of the normal rendering process.
     * These are often used by e.g. SEO plugins that render the content in additional contexts, e.g. to get an excerpt via an output buffer.
     * In these cases, we don't want to enqueue the CSS, as it would likely not be printed on the page.
     */
    if ( doing_action( 'wp_head' ) || doing_action( 'wp_footer' ) ) {
        return;
    }

    // Prevent repeated execution via a static variable.
    static $css_enqueued = false;
    if ( $css_enqueued && ! doing_action( 'enqueue_block_assets' ) ) {
        return;
    }
    $css_enqueued = true;

    /**
     * Filters whether the TablePress Default CSS code shall be loaded.
     *
     * @since 1.0.0
     *
     * @param bool $use Whether the Default CSS shall be loaded. Default true.
     */
    $use_default_css = apply_filters( 'tablepress_use_default_css', true );
    $use_custom_css = TablePress::$model_options->get( 'use_custom_css' );

    if ( ! $use_default_css && ! $use_custom_css ) {
        // Register a placeholder dependency, so that the handle is known for other styles.
        wp_register_style( 'tablepress-default', false ); // phpcs:ignore WordPress.WP.EnqueuedResourceParameters.MissingVersion
        return;
    }

    $custom_css = TablePress::$model_options->get( 'custom_css' );
    $use_custom_css = $use_custom_css && '' !== $custom_css;
    $use_custom_css_file = $use_custom_css && TablePress::$model_options->get( 'use_custom_css_file' );
    /**
     * Filters the "Custom CSS" version number that is appended to the enqueued CSS files
     *
     * @since 1.0.0
     *
     * @param int $version The "Custom CSS" version.
     */
    $custom_css_version = (string) apply_filters( 'tablepress_custom_css_version', TablePress::$model_options->get( 'custom_css_version' ) );

    $tablepress_css = TablePress::load_class( 'TablePress_CSS', 'class-css.php', 'classes' );

        // Determine Default CSS URL.
    $rtl = ( is_rtl() ) ? '-rtl' : '';
    $unfiltered_default_css_url = plugins_url( "css/build/default{$rtl}.css", TABLEPRESS__FILE__ );
    /**
     * Filters the URL from which the TablePress Default CSS file is loaded.
     *
     * @since 1.0.0
     *
     * @param string $unfiltered_default_css_url URL of the TablePress Default CSS file.
     */
    $default_css_url = apply_filters( 'tablepress_default_css_url', $unfiltered_default_css_url );

    $use_custom_css_combined_file = ( $use_default_css && $use_custom_css_file && ! SCRIPT_DEBUG && ! is_rtl() && $unfiltered_default_css_url === $default_css_url && $tablepress_css->load_custom_css_from_file( 'combined' ) );
    if ( $use_custom_css_combined_file ) {
        $custom_css_combined_url = $tablepress_css->get_custom_css_location( 'combined', 'url' );
        // Need to use 'tablepress-default' instead of 'tablepress-combined' to not break existing TablePress Extensions.
        wp_enqueue_style( 'tablepress-default', $custom_css_combined_url, array(), $custom_css_version );
        if ( did_action( 'wp_print_styles' ) ) {
            wp_print_styles( 'tablepress-default' );
        }
        return;
    }

    if ( $use_default_css ) {
        wp_enqueue_style( 'tablepress-default', $default_css_url, array(), TablePress::version );
    } else {
        // Register a placeholder dependency, so that the handle is known for other styles.
        wp_register_style( 'tablepress-default', false ); // phpcs:ignore WordPress.WP.EnqueuedResourceParameters.MissingVersion
    }

    $use_custom_css_minified_file = ( $use_custom_css_file && ! SCRIPT_DEBUG && $tablepress_css->load_custom_css_from_file( 'minified' ) );
    if ( $use_custom_css_minified_file ) {
        $custom_css_minified_url = $tablepress_css->get_custom_css_location( 'minified', 'url' );
        wp_enqueue_style( 'tablepress-custom', $custom_css_minified_url, array( 'tablepress-default' ), $custom_css_version );
        if ( did_action( 'wp_print_styles' ) ) {
            wp_print_styles( 'tablepress-custom' );
        }
        return;
    }

    $use_custom_css_normal_file = ( $use_custom_css_file && $tablepress_css->load_custom_css_from_file( 'normal' ) );
    if ( $use_custom_css_normal_file ) {
        $custom_css_normal_url = $tablepress_css->get_custom_css_location( 'normal', 'url' );
        wp_enqueue_style( 'tablepress-custom', $custom_css_normal_url, array( 'tablepress-default' ), $custom_css_version );
        if ( did_action( 'wp_print_styles' ) ) {
            wp_print_styles( 'tablepress-custom' );
        }
        return;
    }

    if ( $use_custom_css ) {
        // Get "Custom CSS" from options, try minified Custom CSS first.
        $custom_css_minified = TablePress::$model_options->get( 'custom_css_minified' );
        if ( ! empty( $custom_css_minified ) ) {
            $custom_css = $custom_css_minified;
        }
        /**
         * Filters the "Custom CSS" code that is to be loaded as inline CSS.
         *
         * @since 1.0.0
         *
         * @param string $custom_css The "Custom CSS" code.
         */
        $custom_css = apply_filters( 'tablepress_custom_css', $custom_css );
        if ( ! empty( $custom_css ) ) {
            wp_add_inline_style( 'tablepress-default', $custom_css );
            if ( did_action( 'wp_print_styles' ) ) {
                wp_print_styles( 'tablepress-default' );
            }
            return;
        }
    }
}
    Plugin Author TobiasBg

    (@tobiasbg)

    Hi,

    yes, that’s the code that loads the CSS files. It’s possible that the initial checks in that function fail, but not because they are incorrect, but maybe because some additional condition is needed.

    I’m currently investigating that ??

    Best wishes,
    Tobias

Viewing 11 replies - 1 through 11 (of 11 total)
  • You must be logged in to reply to this topic.