My Very First Theme, And a Few Questions

Some small suggestions, because i don’t have time to go over the theme in full.

Add all the WP generated classes, there’s possibly more, but this is the only list i can find.
https://codex.www.ads-software.com/CSS#WordPress_Generated_Classes

RE: Search form, just call get_search_form in the appropriate place, header or wherever..

<?php get_search_form(); ?>

If that’s problematic, remove the template you have for the search form(searchform.php), and let WordPress pull the default one(you’ll rule out a problem with the template if it doesn’t help).

Remove unnecessary whitespace from template files.. here’s one example(index.php of your theme)..

<div class="clip"></div>
<?php } ?>

        </article>

Seven lines of whitespace.. (one line of space would be fine, but seven is a little silly).

EDIT: Forum stipped out the extra lines of whitepace, hence why they can’t be seen above.

Don’t use shorthad PHP tags in template files, again i’m referring to index.php..

<?
global $options;

Not all setups have shorthand tags enabled, it’s good practice to use full PHP tags for any PHP code you write.

<?php

and not..

<?

The get_settings function is deprecated, any calls to this function should be replaced with get_option…

That’s what i picked up on at first glance.. hope that helps.. ??

P.S. Overall it looks like a very well done conversion, i’ve seen quite a few done, and this is definately one of the better ones i’ve seen.

That helps a lot actually. Thanks a ton. And thanks for the compliment.

This is exactly the type of stuff I need. I’ll have most if not all of this done by tonight.

Thanks again. I appreciate it.

For a first effort and in a short time it looks stunning. Not sure u need our help at all ??

Well, I wish I could take credit for the aesthetics, but it was that of a friend’s. I just broke it up, made it a WP theme and added some functionality (I’ve always been partial to “business” type themes).

But thank you very much for the complements. I’m really enjoying myself, and the community is pretty B.A.

u do have that wierd thig of all the \\\\\\\\\\\\\\\\\\\ in the branding headline………but then u can move on to jquery carousels n stuff………

@root,

Yeah, that’s bugging the hell out of me right now. It appears any time there’s a quotation (“) or apostrophe (‘) input into any of the fields on my admin theme options page.

There are a few threads out there dealing with the same issue, but they all revolve around specific plugins. I’m apparently going to have to dig pretty deep to fix that as I am very novice in the ways of PHP.

Man, it sure is ugly though.

Have you reviewed Data_Validation?

Hey esmi,

Thanks, I think that is what I’m looking for. At least it seems to be. I’m still learning PHP as I go, so it’s a bit out of my ability at the moment. I think what I’m looking at, according to the descriptions is using

esc_html( $text )

but I’m just not sure how to implement it yet. But I’m pretty sure that’s exactly what I’m looking for. Thanks, esmi.

You may find the following example is a much better approach to handling theme options.
https://themeshaper.com/sample-theme-options/

One major difference you’ll find with this method is that you’ll be storing your options in array as a single option(ie. only one entry in the database) which is hugely preferable to storing each option in it’s own entry(which your theme is currently doing).

The sample also utilises the settings api for the theme options, and provides a decent enough example of sanitizing differing types of options.

Alternatively you can always use a method like this to convert your options into a single array of options.
https://ptahdunbar.com/wordpress/consolidate-options-with-arrays-in-your-wordpress-themes/

Awesome. Thanks, Mark. Let me check that out.

Mark,

In this code, there is a part that “sanitizes” the input. I assume this is to help with the apostrophes causing issues. I just have a quick question. In the code currently is:

// Say our text option must be safe text with no HTML tags
	$input['sometext'] = wp_filter_nohtml_kses( $input['sometext'] );

So, I would have to add one for each input I create, yeah? This is relating to the first link you sent. I already like this method a lot better. It’s a little cleaner and easier for me to understand what’s going on.

Scratch that, sorry. It appears that that is used to ensure that HTML is not placed into the field.