[Plugin: Posts 2 Posts] Upgrade from 1.0.1 to 1.1.1 failed

Strange, it works fine for me.

The fastest way for me to fix this would be if I had admin access to your setup, ideally in a staging environment.

My email is mail @ scribu.net

Strange indeed.
I cannot give you access to our staging environment, but i might be able to debug it myself if you can point me towards the ‘import’ function? Any clues on what the value of the p2p_type column should be is also greatly appreciated

The p2p_type column should contain the name of the connection type, i.e. ‘publications_to_referenties’ from your example.

The upgrade script is located in core/storage.php.

I looked at the upgrade function. When this function tries to receive the posts to do the upgrade with.. it ends up with an empty array.. so no updating takes place at all.

This is my $args array for the get_posts () function:

Array
'post_type' =>
array
0 => string 'post' (length=4)
'suppress_filters' => boolean false
'ignore_sticky_posts' => boolean true
'connected_items' => string 'any' (length=3)
'cache_results' => boolean false
'post_status' => string 'any' (length=3)
'nopaging' => boolean true
'connected_direction' => string 'any' (length=3)
'connected_meta' =>
array
empty


I’m also not sure how this is going to get posts at all, so could you have a look at it and tell me why this isn’t working for me?

I think I know what’s going on. You’re calling p2p_register_connection_type() before the post types are defined.

To check, simply add this line above your call to p2p_register_connection_type():

var_dump( post_type_exists( 'frr_publications' ) );

That did it! Both where called on ‘init’. I changed the order they are called.
Strangely the connections meta boxes etc are working nonetheless.

Some ideas here:
– When making a connection could you do a check whether or not the actual posttype exists? And if not show an admin_notice of some kind?
– When registering a connection no validation is done on the length of the id.. but the connection id is later on stored in a varchar(32) field. This may also lead to problems.

– When making a connection could you do a check whether or not the actual posttype exists? And if not show an admin_notice of some kind?

Yeah, in the development version a PHP notice is triggered.

– When registering a connection no validation is done on the length of the id.. but the connection id is later on stored in a varchar(32) field. This may also lead to problems.

That’s also a good idea.