New Plugin: Expand Comments (w/ AJAX)

Looks good, though one suggestion – would it be possible to make the expand link only appear if there is at least one comment? I found myself trying to expand a ‘no comments’ post and wondering why it was not working.

Hm, I was thinking that myself. I suppose it wouldn’t be too hard to add that, I really just want to make sure that it works on most/all browsers before adding things. That’s definitely something I’m going to add though. Would it be better to remove the link entirely? or have it show up as the rss link instead?

I would go for total removal, a link to the rss might be confusing for people.

Kickass!

*downloads*

Edit: You need to loose the whitespace at the beginning and end in your plugin. ??

Edit #2: Mispelling on your page. You have an s in the function name: <?php expand_comments_link(); ?>

whitespace? could you specify please?

You have a line break before your first <?php and after your last ?>.

Edit: You also have an s in the function name for the div on your install page too: <?php expand_comments_div(); ?>

Edit #2: Hmm, when I click the link, it takes me to the feed for the post and doesn’t expand the comments. Yep, the JS is working as it’s replacing the “RSS” with “Expand Comments” and I see the plugin’s <div> in my source code, so weird…

Uploaded / activated the plugin on my test site. Perhaps you can figure out what the problem is…

https://test.viper007bond.com/wordpress-latest/#post-9

Perhaps this is the problem?

https://validator.w3.org/check?verbose=1&uri=http%3A%2F%2Ftest.viper007bond.com%2Fwordpress-latest

ahh, you know what that is, its because the expand-comments.js include is just a relative url, not a full y qualified url. At least that’s my first guess, since firefox says makeAjaxRequest isn’t a defined js function.

Give me a short while to fix, thanks

alright, try redownloading it now. Also, I added the “no comments, no link” feature

w.r.t. the invalid, I’ll have to fix that, but I don’t think that’s the problem. so far the plugin is XHTML 1.0 trans. validated, but I’m not up on all the specs, so I’ll have to look into that

Sweet, works now! ??

Although IMO the expand_comment_link() function should accept parameters of what to output before and after the link (so that the stuff only shows up if the link is gonna show up).

Also, the comments div shouldn’t show up if there’s 0 posts. Waste of HTML. ??

Awesome! glad it works ??

yeah, I want to expand upon expand_comment_link so the text isn’t hardcoded, etc. What do you mean by ‘so the stuff only shows up’? which stuff?

also, I’ll fix the div part too so it uses the same if comment # > 0 code.

finally, w.r.t. the XHTML 1.1, it looks like the name attribute doesn’t exist for anchor tags. Does the title attribute work similarly? IE: can I use the title attr to get those objects out of the DOM? right now the name attr is used so that the link can be ‘ajaxified’ by doing a document.getElementsByName() call. if Title can be used the same way, then this should be made XHTML 1.1 compliant very easily

Still having this issue as described by Bond:

Edit #2: Hmm, when I click the link, it takes me to the feed for the post and doesn’t expand the comments. Yep, the JS is working as it’s replacing the “RSS” with “Expand Comments” and I see the plugin’s <div> in my source code, so weird…

there’s also an issue with the nature of AJAX that’s noted in the readme, namely, if a person is on your site at, say, https://www.site.com, and the wordpress install and all the links are at site.com (no www.) then the browser security will stop ajax from retrieving anything. Basically browsers think that you don’t want it to get data from anywhere but where you’re currently browsing.

I haven’t had time to look into it too much, but my ‘quick fix’ is to redirect requests to https://www.nymb.us to nymb.us, and all works.

where are you trying to get this to work at?

edit: to clarify, if your RSS link is, say, https://nymb.us/?feed=rss2&p=39 but the user is at https://www.nymb.us, when they click the link, the ajax request is made to https://nymb.us/?feed=rss2&p=39, and NOT https://www.nymb.us/?feed=rss2&p=39. since technically these represent different sites to the browser, it fails, and the RSS is displayed instead.

Hey Bitwise,

Can you have a look at my site please *linked to my username*. The link is below the content.

Thanks so much