Twenty Fourteen core (variety of concerns)

  • Resolved dsalon

    (@dsalon)


    11 years, 1 month ago

    I like the twentyfourtenn theme and this plugin very much and am currently testing them on a LAN server…

    now since in this plugin’s description there is mentioned:

    “The Accent Color feature was originally developed in Twenty Fourteen core, but it was removed near the end of the development cycle due to a variety of concerns…”

    I would be very happy if the developers were to let me know shortly the most seriuos of said “variety of concerns”…

    Thank you very much in advance.

    https://www.ads-software.com/plugins/fourteen-colors/

Viewing 1 replies (of 1 total)
  • Plugin Author Nick Halsey

    (@celloexpressions)

    Most of these concerns have since been addressed in the development of the plugin, after the feature was removed from core. However, you can see most of the final discussion here: https://core.trac.www.ads-software.com/ticket/26220, and in the linked IRC logs. I believe the initial discussions took place during WordCamp London, although I wasn’t there and those are undocumented.

    The only lingering thing that might be a concern is that the colors CSS is loaded via <style> tags in the <head> rather than from an external file (some people don’t like this but there’s nothing technically wrong with it). However, the entire CSS is generated only when the colors change, then cached, so this shouldn’t be a big concern. You can also write and add-on plugin that loads it from a file rather than in the <head>. The biggest issue was that certain color choices could result in insufficient contrast between text and background colors; the plugin now calculates contrast ratios and adjusts the colors as needed to fix any issues.

Viewing 1 replies (of 1 total)
  • The topic ‘Twenty Fourteen core (variety of concerns)’ is closed to new replies.