Paragraph Breaks No Longer Preserved

Hi crowinck,

There’s a line in the Advanced Excerpt code that reads:

$text = apply_filters( 'the_content', $text );

So wpautop should definitely be applying correctly to the excerpt text.
Perhaps your theme or another plugin is removing the wpautop filter at some point?

Would you be able to try out the latest development copy of the plugin over on our git repo? https://github.com/deliciousbrains/wp-advanced-excerpt/archive/master.zip

It may make a difference as I’ve reverted the way we retrieve the post’s content (back to the 4.1 method).

Cheers,

Chris

Unfortunately this version didn’t make a difference. I tried disabling all the other plugins without effect. However, I did manage to see paragraph breaks in the excerpts by briefly switching the theme to twenty-ten and going to the search page.

So it could be a theme compatibility issue, though I haven’t made any recent changes to the theme that would affect content filtering, and I’m pretty sure it started with the last update.

If you want to try anything else that would be great, but if you don’t want to pursue it, I can troubleshoot potential theme issues for a while.

Would you be able to let me know how your theme is outputting the excerpts, i.e. which function it is using.

the_content()
get_the_content()
the_excerpt()
get_the_excerpt()
the_advanced_excerpt()

etc

You may want to cross reference this with what the search template in twenty-ten is doing.

Both templates are using the_excerpt()

I’m going to look through the theme where it isn’t working and see what excerpt filters it has, and if disabling them makes a difference.

Hi there,

First of all, the real issue is that the plugin isn’t filtering at all, the only immediate visual difference was the lack of line breaks, because I had a number of other filters for adding the more link, etc, when your plugin wasn’t in use. Sorry about the mis-assessment.

I have done bunch of testing, and determined that the plugin stops running on line 88 of class/advanced-excerpt.php, with this test:

`if ( !empty( $page_types ) && !empty( $page_type_matches ) ) return;’

The page in which the plugin is no longer working is front-page.php. This page has several loops, one from the page assigned as the front page, and others to draw in content from around the site. It must be falling through the cracks when you are doing your page types tests.

In the settings for the plugin, I have not disabled it for any specific page/page type, so it should be running.

Does this give you enough info to fix this bug? Do you need anything else?

Hi crowinck,

Are you able to try something for me?

Would you be able to edit the plugin for me and add:

printf( '<pre>%s</pre>', print_r( $page_types, true ) );

Right above the line that reads:

if ( !empty( $page_types ) && !empty( $page_type_matches ) ) return;

Please then reload your frontpage and tell me what you see.

Also, just to confirm, your current theme is running the_post() on in your frontpage template right?

Cheers,

Chris

The front page has three loops, one uses the_post() on the main query object, the second uses setup_postdata(), and the third uses the the_post() on a new WP_Query object. It’s this third one where the plugin used to work and doesn’t anymore. It’s possible I need to reset postdata after the second loop… naw, doesn’t make a difference.

Here’s what I’m seeing before loops 1 and 3:

Array
(
    [0] => page
    [1] => singular
)

Are you planning on doing a fix for this?

It would just be nice to know whether I’ll have to comment that conditional on every update to keep the plugin working.

Yes I am! I’ll have something for this soon.