4.2.3 Security Update created broken [types field] links

Same thing is happening with us at the moment… Awaiting a response!

I’m guessing it has something to do with the “shortcodes within HTML tags” update but I can be wrong. Here’s a link to those updates…

https://core.trac.www.ads-software.com/changeset?sfp_email=&sfph_mail=&reponame=&old=33360%40branches%2F4.2&new=33360%40branches%2F4.2&sfp_email=&sfph_mail=

Wonderful… We are in the process of working it out but this is no good at all. Dang automatic updates breaking your site is not acceptable WordPress…

The problem you’re describing is due to a changes to the way shortcodes are parsed in wp-includes/shortcodes.php. Just saw alans0830’s reply and that indeed is the problem. Types/Views and other ToolSet plugins (indeed many other plugins) depend upon templates that mix HTML and shortcodes.

The workaround for me was to replace the 4.2.3 version of wp-includes/shortcodes.php with the one from 4.2.2 and to turn off automatic core updates in wp-config.php by adding the line define( ‘WP_AUTO_UPDATE_CORE’, false );

Let me know if you find a permanent solution. Restoring to backup everytime it WP updates probably isn’t ideal.

I’ll give that a shot NCPTT, thanks!

Thanks for the response NCPTT. Very helpful!

Is that restricting core updates to ALL files? If so, can we just restrict shortcodes.php?

Same problem here. This is a big issue and I think from now a lot of people will reconsider leaving auto-update on.

I replaced my wp-includes/shortcodes.php with the version from 4.2.2 for now as a temporary fix.

This seems to be a problem with Types, not WordPress.
Keep an eye on https://wp-types.com/forums/topic/types-shortcode-breaks-after-wordpress-4-2-3-autoupgrade/

Types is saying it’s WP. Regardless, I understand the frustration.

You’re right, Alan. My temporary fix was to replace shortcodes.php, but I’m rolling back to 4.2.2 now. I’m checking other plugins on my development workstation under 4.2.3 to see what else is broken.

define( ‘WP_AUTO_UPDATE_CORE’, false ); disables all files since core updates are all-or-nothing. It’s normally a bad idea to mix and match core files from different versions as it can break things, but this case was one of those exceptions.

I think improved security was the rationale for this change to the way shortcodes are parsed. I’d be surprised if there wasn’t a 4.2.3.1 patch released soon. There’s also likely to be a quick update for the wp-types.com ToolSet suite of plugins.

Here’s the discussion thread about the problem as it pertains to ToolSet: https://wp-types.com/forums/topic/types-shortcode-breaks-after-wordpress-4-2-3-autoupgrade/

Note: You may need an account at wp-types.com to view that thread.

“I replaced my wp-includes/shortcodes.php with the version from 4.2.2 for now as a temporary fix.”

We just did that as well on our beta site and it worked fine for now. Keeping an eye out for permanent fix, thanks!

I plan on doing the same and keeping an eye out for permanent fix. Thanks everyone! If anyone sees communication from WP or Types, please post.

Problem is not only for WP-Types, but for all plugins and custom shortcodes that mixes shortcodes with html. I think it’s a WordPress fault in this case.