Forums not being restricted

Note that the url of the dev site forums page is: https://devhof.churchwebprogram.com/forums/?noaccess=1

So it “knows” that it’s supposed to not have access… but it’s displaying the forums anyway.

Did you try with a default WP theme like twenty-fifteen? I have a suspicion it’s from your iThemes Builder but I’m not certain of it.

PMPro bbPress will not hide the existence of the forums by default. But it will redirect anyone loading a thread out of that forum.

Here is a code gist you can use to hide the forums from the list as well:
https://gist.github.com/strangerstudios/cc30ee167aa7e3edeaa7