Feature request

  • Resolved Jory Hogeveen

    (@keraweb)


    8 years, 9 months ago

    I hope you guys are willing to come up with this:

    Enable non-destructive watermarking of the original images as an option.

    Problem:
    When watermarking images exept the original, these images can still be found and indexed.

    Sollution:
    Create an option to store all original images in a backup folder within the uploads folder that the image is located.
    The user can then use .htaccess to fully protect their original content.

    Todo: (when the option is enabled)

    • Create backupfolder “watermark-backup” within the images uploads folder (example: **/2016/02/watermark-backup/)
    • When saving the original image with a watermark, create a backup in the backup folder
    • When saving images with a new watermark, allways use the backup image if one is available. (htaccess wont be a problem since you’ll be working server-side).

    I can provide help on this if that is ok!
    Also, I you won’t implement this. Can you provide hooks in the plugin that I can use you implement this myself?

    https://www.ads-software.com/plugins/image-watermark/

Viewing 15 replies - 1 through 15 (of 27 total)
  • Thread Starter Jory Hogeveen

    (@keraweb)

    https://www.ads-software.com/plugins/easy-watermark/

    The above plugin creates a new folder in wp-content for the backups with the same structure as the uploads folder.
    This way it is really easy to create htaccess redirects.

    Please respond to this. Your plugin does the image handling way better so I’d like to keep using this plugin but the backup feature is mandatory in my case.

    Hoop you can look into this! Please let me know.

    Plugin Author dFactory

    (@dfactory)

    Thx for the feedback @jory

    For now we focused on implementation of Image Magic, if supported by yout server (which is much better method than GD Library)

    After we do that, we’ll definitely get back to the backup idea.

    Regards,
    Bartosz / dfactory team

    Thread Starter Jory Hogeveen

    (@keraweb)

    Hi Bartosz,

    I’ve noticed the update on ImageMagic!
    Let me know if/when we could look at the backup posibilities!

    Regards, Jory

    Plugin Author dFactory

    (@dfactory)

    Hey Jory,

    We will introduce it buy hard to say when. Probably this will be a major update, that will combine image regeneration functionality too, so it will take while.

    Thread Starter Jory Hogeveen

    (@keraweb)

    Understandable, let me know if I can help (Github?)

    Plugin Author dFactory

    (@dfactory)

    Just pushed it to Git:
    https://github.com/dfactoryplugins/image-watermark

    Thanks Jory

    Thread Starter Jory Hogeveen

    (@keraweb)

    Created a fork:
    https://github.com/JoryHogeveen/image-watermark

    DONE:

    • Create image backup in folder wp-content/iw-backup/**imagepath**
    • Create htaccess security in the iw-backup folder
    • Delete backup image when an image is deleted

    TODO:

    • (regenerate thumbnails feature)
    • Recreate watermark images with help of the backup image
    • Recreate images without watermark with help of the backup image
    • ???
    Thread Starter Jory Hogeveen

    (@keraweb)

    Current status:

    • Regenerate images
    • Removing watermarks can be done with a bulk action (just like applying watermarks, this action also regenerates all thumbnails
    • This now also prevents double watermarks for images (apply watermark removes the current watermark first)
    • Store a metavalue “iw-is-watermarked” when an image is watermarked
    • If no backup is made: use the current full-size image to recreate the thumbs

    TODO:

    • Bulk actions with AJAX. (prevens server timeout when selecting a large number of images
    • Notices and explanation of usage for users
    Thread Starter Jory Hogeveen

    (@keraweb)

    Current status:

    • Bulk actions with Ajax done
    • Ajax also shows various notices and update feedback when doing bulk actions

    TODO:

    Test it on various installations!

    Some screenshots:

    Settings page
    Bulk action running
    Bulk action success/finished

    Code:

    Repository:
    https://github.com/JoryHogeveen/image-watermark

    Filechanges:
    https://github.com/dfactoryplugins/image-watermark/compare/master…JoryHogeveen:master

    Plugin Author dFactory

    (@dfactory)

    Fantastic work Jory,

    We’ll download that and do some testing,

    Thread Starter Jory Hogeveen

    (@keraweb)

    Just did a minor update on the javascript bulk update.
    Rotation of the icon is now looping and stopping correctly.

    Thread Starter Jory Hogeveen

    (@keraweb)

    Another idea. What about apply/remove watermark in the modal windows and edit-attachment screens?

    Screenshots (not functional):

    Edit attachment
    Media modal

    Thread Starter Jory Hogeveen

    (@keraweb)

    Github repository now also has the buttons in the edit and modal screens enabled :).

    I’ve changed and renamed the bulk-action script to be able to do updates on more locations than just the upload.php page. It is now enabled on the upload.php page, the post.php (attachment edit) page and all the media-modal windows/popups.

    I currently load this script on every page because the image modal could be loaded on various locations. Also, because of the modal, all images and edit fields are loaded with javascript so I doubt we can’t know on what page we are for checks.

    Again, let me know what you think about it so far. (Idea to get in touch on Slack?)
    We’ll need some time with testing I would say!

    Thread Starter Jory Hogeveen

    (@keraweb)

    Another fix applied for multisites.

    I’ve copied the default wordpress folder structure for multisite installations.
    (sites/*siteid*/etc.)

    We don’t need to check for a possible customized folder structure since the backup structure has it’s own management from this plugin.
    Even if the default folder structure is customised, our own backup structure will still work.

    https://github.com/JoryHogeveen/image-watermark/commit/ca8a5a5dba2ba92060860bcbe8672fa25a5baa2e

    Thread Starter Jory Hogeveen

    (@keraweb)

    Hi Bartosz,

    Did you manage to test the changes?
    Also, any feedback or todo’s?

    Let me know!

    Regards, Jory

Viewing 15 replies - 1 through 15 (of 27 total)
  • The topic ‘Feature request’ is closed to new replies.