Does what it says

  • thicket

    (@thicket)


    10 years ago

    I came across a few bugs – some functional, some cosmetic which I have corrected in the installed version. Does not seem to be a way to pass this on to the author!!

    The end of file error is due to <? short open tag usage in function bf_map_settings_page(){} in magic-Maps.php. Change to <?php to fix or set short_open_tag = On in php.ini

    I also changed all [dD]escryption -> [dD]description (do this in .js files as well) – purely cosmetic

    Also get warnings, notices for use of uninitialised var in `function enable_description(){}. I added code to handle this.

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Fengler

    (@fengler)

    Hi Thicket

    I thought I have fixed all short tags in version 1.0.1 but it looks like I’ve missed one, I’ll check that . Thanks for finding typo and overall help.

    Thread Starter thicket

    (@thicket)

    Haven’t got them all yet – in V 1.0.3 in magic-Maps.php

    line:214 still has php short open tag
    line:222 still has php short open tag

    Still the uninitialised variable:

    function enable_description(){
    $enable_description = get_option('enabledescription');
    /* uninitialised variable
    $html = '<input type="checkbox" id="Enabledescription"    name="Enabledescription" value="1"'.checked( 1, $enable_description['Enabledescription'], false ) .' />';
    */
    // --- my change
    $checked = empty($enable_description) ? '' : ' checked ';
    $html = '<input type="checkbox" id="EnableDescription" name="EnableDescription" value="1"' . $checked . '/>';
    // --- end of change

    $html .= '<label for="checkbox_example">Display or hide Info window</label>';
    echo $html;
}

    Plugin Author Fengler

    (@fengler)

    Hi thicket

    There is nothing better than extra pair of eyes. Thanks again.
    I fixed that checkbox with one line

    $html = ‘<input type=”checkbox” name=”Enabledescription” value=”1″ ‘. checked( $enable_description , 1 , false) .’ />’;

    But the result is the same.

    Thanks again.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Does what it says’ is closed to new replies.