Elegant Theme code inside Popup Maker code

@jutta0303

Sorry you’re having difficulties, I’m sure we can this resolved.

I’ll have our Lead Dev @danieliser take a look as soon as possible.

Thank you for being patient.

Thank you for the response!

@jutta0303 – Funny enough this comes up a lot. Unfortunately its something in the way they are filtering post_meta. I don’t have access to their themes, but do know from debugging that the data stored in post meta does not contain that extra text, so it is added when loaded. The problem is we don’t use any filters that could conflict. That data is passed through one filter on our end pum_popup_data_attr which is obviously not where the issue is occurring. This only leaves them filtering get_post_meta before we get the data.

Hard to figure out without access to their code, but might be worth a shot trying their support to see how it might be occurring based on the above info.

Cool. Thanks @danieliser. They did ask me to pass on any information I might get from you, especially if it seemed like it might some issue on their end. So, I’ll pass on what you wrote to Elegant Themes and see how that goes.

Appreciate the reply!

@jutta0303 – This may help as well. This is the function in question. https://github.com/PopupMaker/Popup-Maker/blob/master/includes/class-pum-popup.php#L356-L385

Hope that helps, let me know.

Great! Thanks!

Hi @danieliser,

Elegant came back with the following reply:

Since you can still see the message while all of our products are deactivated, there is really nothing we can do about it. You can send them a copy of the theme after downloading it from your member area to check the code.

So, if you like, I can provide the theme files for you. Just let me know of the best way to do that.

Thanks!

@jutta0303 – That would be fine. I will track it down locally pretty quickly. You can send it via our support page: https://wppopupmaker.com/support/

Awesome! Have just done that ??

Thanks so much!

Closing this ticket. The conversation has moved to our Support Portal.

As soon as a solution is found, it will be converted to our Documentation, and the link posted in this thread.

Stay tuned, and thanks for the files!

@jutta0303 – I have not been able to reproduce this. I installed the divi theme you sent me and built a test page, even entered some bogus update credentials, couldn’t trigger it.

Any thoughts on how we can make it happen? From you or their support would be helpful in tracking this down.

I am having the same issue.. Using Divi theme and my code shows a lot of garbage.

Any developments on this?

Thanks!

@jutta0303, @paulovsky – I have tried everything I can to duplicate this issue, as have Elegant Themes.

Here is what I have found so far:

This is the data attribute whos data is being corrupted:

{
	"id": 4363,
	"slug": "andy",
	"theme_id": 2817,
	"cookies": [],
	"triggers": [
		{
			"type": "click_open",
			"settings": {
				"extra_selectors": ".andy",
				"do_default": null,
				"cookie": {
					"name": null
				}
			}
		}
	],
	"mobile_disabled": null,
	"meta": {
		"display": {
			"size": "medium",
			"responsive_min_width": "",
			"responsive_max_width": "",
			"custom_width": "640",
			"custom_height": "380",
			"animation_type": "fade",
			"animation_speed": "350",
			"animation_origin": "center top",
			"position_bottom": "<em>Before you can receive product updates, you must first authenticate your Elegant Themes subscription. To do this, you need to enter both your Elegant Themes Username and your Elegant Themes API Key into the Updates Tab in your theme and plugin settings. To locate your API Key, <a href=\"https://www.elegantthemes.com/members-area/api-key.php\" target=\"_blank\">log in</a> to your Elegant Themes account and navigate to the <strong>Account > API Key</strong> page. <a href=\"https://www.elegantthemes.com/gallery/divi/documentation/update/\" target=\"_blank\">Learn more here</a></em>. If you still get this message, please make sure that your Username and API Key have been entered correctly",
			"location": "center top",
			"position_right": "<em>Before you can receive product updates, you must first authenticate your Elegant Themes subscription. To do this, you need to enter both your Elegant Themes Username and your Elegant Themes API Key into the Updates Tab in your theme and plugin settings. To locate your API Key, <a href=\"https://www.elegantthemes.com/members-area/api-key.php\" target=\"_blank\">log in</a> to your Elegant Themes account and navigate to the <strong>Account > API Key</strong> page. <a href=\"https://www.elegantthemes.com/gallery/divi/documentation/update/\" target=\"_blank\">Learn more here</a></em>. If you still get this message, please make sure that your Username and API Key have been entered correctly",
			"position_top": "100",
			"position_left": "<em>Before you can receive product updates, you must first authenticate your Elegant Themes subscription. To do this, you need to enter both your Elegant Themes Username and your Elegant Themes API Key into the Updates Tab in your theme and plugin settings. To locate your API Key, <a href=\"https://www.elegantthemes.com/members-area/api-key.php\" target=\"_blank\">log in</a> to your Elegant Themes account and navigate to the <strong>Account > API Key</strong> page. <a href=\"https://www.elegantthemes.com/gallery/divi/documentation/update/\" target=\"_blank\">Learn more here</a></em>. If you still get this message, please make sure that your Username and API Key have been entered correctly",
			"overlay_zindex": "1999999998",
			"zindex": "1999999999",
			"responsive_min_width_unit": "px",
			"responsive_max_width_unit": "px",
			"custom_width_unit": "px",
			"custom_height_unit": "px"
		},
		"close": {
			"text": "",
			"button_delay": "0"
		},
		"click_open": {
			"extra_selectors": ""
		}
	}
}

The only place this string is located in the Divi theme is

<em>Before you can receive product updates, you must first authenticate your Elegant Themes subscription. To do this, you need to enter both your Elegant Themes Username and your Elegant Themes API Key into the Updates Tab in your theme and plugin settings. To locate your API Key, <a href=\"https://www.elegantthemes.com/members-area/api-key.php\" target=\"_blank\">log in</a> to your Elegant Themes account and navigate to the <strong>Account > API Key</strong> page. <a href=\"https://www.elegantthemes.com/gallery/divi/documentation/update/\" target=\"_blank\">Learn more here</a></em>. If you still get this message, please make sure that your Username and API Key have been entered correctly

Is only located in the themes /core/admin/includes/class-updates.php:415.

It is only called when there is an update but either no key is entered or the key is not valid.

Based on that I am not sure what to think. We have a new version going into testing shortly. I would like to see if it happens with new popups created after that version is released.

I am also adding some sanitization to those fields that are getting corrupted so that they will hopefully be reset on each save of the popup.

Hi!

Thanks so much for the follow-up! Is there anything for me to do at the moment; should I pass any of this onto the guys from Elegant Themes? Anything I can test on my end?