plugin doesn’t properly escape delimiter in google fonts url

Hi,

Thanks for letting me know, however this is intentional because that’s the format used by google themselves, ie: https://pasteboard.co/IhHJH00B8.png

Furthermore, W3C is irrelevant if you have an HTML5 theme as a large part of it fails the normal W3C validation, ie: https://www.impressivewebs.com/understanding-html5-validation/

You can however select the option to “inline google fonts” and the validation error will be gone.

Thanks

The link about html5 validation you posted is 5 years old and my html5 wordpress page is validated without errors except the one with the google fonts.

When I escape the pipe character it is validated fine and it is still working. And it looks like other projects escaped it as well:
https://github.com/asciidoctor/asciidoctor/issues/1126

And on https://developers.google.com/fonts/docs/getting_started on the section “Optimizing your font requests” they write “As with all query strings, you should URL-encode the value”.

I understand your point on this one too and I’ll consider url encoding the urls on the next version.

However, the google url you’ve sent, you’re interpreting it wrong.
It says that you should url encode the “values”, as in: “Hello World” to “Hello%20World” and not the rest. That being said, “we know” chars should be urlencoded regardless of what google gives us.

Wait for a couple of days an a new update will be out.