“liveblog”; known 2.2 issues

  • ResolvedPlugin Author Optimizing Matters

    (@optimizingmatters)


    7 years, 8 months ago

    I’ll document confirmed bugs here the next couple of days.

    First one;
    -> problem: images referenced in CSS not translated to correct path, leading to 404’s
    -> fix; open wp-content/autoptimize/classes/autoptimizeStyles.php and on line 6 replace
    const ASSETS_REGEX = '/url\s*\(\s*(?!["\']?data:)(?![\'|\"]?[\#|\%|])([^)]+)\s*\)([^;},]*)/i';
    with
    const ASSETS_REGEX = '/url\s*\(\s*(?!["\']?data:)(?![\'|\"]?[\#|\%|])([^)]+)\s*\)([^;},]*)/iU';
    (so adding capital U to make the regex ungreedy)

Viewing 15 replies - 1 through 15 (of 66 total)
  • Plugin Author Optimizing Matters

    (@optimizingmatters)

    next up;

    -> problem

    Uncaught Error: [] operator not supported for strings in /…/wp-content/plugins/autoptimize/classes/autoptimizeStyles.php:71″ error in PHP7.1

    -> fix (to be confirmed); in autoptimizeStyles.php on line 67 change

    $this->dontmove = "";
    into
    $this->dontmove = array();

    Plugin Author Optimizing Matters

    (@optimizingmatters)

    fix for “operater not supported” confirmed working by @netzblogr, thanks Falk Wussow!

    Plugin Author Optimizing Matters

    (@optimizingmatters)

    the ASSETS_REGEX will become
    const ASSETS_REGEX = '/url\s*\(\s*(?!["\']?data:)(?![\'|\"]?[\#|\%|])([^)]+)\s*\)([^;},\s]*)/i';

    instead, same result but more performance-efficient then adding the U flag.

    Hi ??
    I updated it and a lot of styles broke, I downgraded to 2.1.1.

    Plugin Author Optimizing Matters

    (@optimizingmatters)

    better use https://downloads.www.ads-software.com/plugin/autoptimize.2.1.2.zip instead

    would like some more on styles that broke though ..

    When I enable “Optimize CSS Code” no styles load. I don’t see any 404 errors either. I can re-create the issue on production and when working locally.

    Plugin Author Optimizing Matters

    (@optimizingmatters)

    do you have a (non-prod) site where I could see this happening @twistermc?

    It’s a client’s site and it’s under NDA. I’m trying to reproduce on another client’s site but haven’t had time yet.

    I updated to version 2.2.0 from version 2.1.2 on both my websites and it only caused issues with one of them.

    TsunamiPremiumVapor.com seems to be working fine with the new version, however I had to rollback B2Bvapors.com to 2.1.2 because it broke a bunch of stuff. Which is odd because I have the autoptimize settings configured the same for both websites and they both use the same theme.

    Here are the things I noticed it broke before I rolled it back…

    1. My pages that I created with Live Composer ( Like https://b2bvapors.com/e-liquid-vaporizers/shock/ ) wouldn’t show any of the page content I added using Live Composer.

    2. My WooCart plugin didn’t seem to work at all ( I also use this plugin on TsunamiPremiumVapor.com and the update didn’t break it on that site for some reason.

    3. My WooCommerce Filter By Price Widget lost all its styling and didn’t work the way it used to with the little bar that can slide back and forth to change price range.

    I’m sure there were other issues I didn’t notice as well.

    Thanks,

    Plugin Author Optimizing Matters

    (@optimizingmatters)

    @marketing2:
    * would be interesting to know if the problem went away when disabling JS optimization or when disabling CSS optimization (to make sure which triggers the errors)
    * would be interesting to know if there were JS errors on the browser console
    * do you have a non-production version of b2bvapors.com where we could look into this?

    frank

    Sorry for delay, Ok, I checked again. Updated to 2.2.2 and my style broke without any js error so I turned off this option:

    Inline and defer css

    Now there is no issue at all. But I experience flash of unstyled content.

    • This reply was modified 7 years, 8 months ago by Amir.
    Plugin Author Optimizing Matters

    (@optimizingmatters)

    can you share your URL so I can have a look @repenter?

    Sure:
    https://www.ajibtarin.com/

    Plugin Author Optimizing Matters

    (@optimizingmatters)

    oh, but you have some plugin which is pushing the CSS to the footer , which probably causes the JS that loads the deferred CSS to fail @repenter

    
<!-- We need this for debugging themes using Speed Booster Pack Plugin v3.3 --> <!-- CSS to footer: enabled -->

    so disable that and retry “inline & defer”, it will most likely work ??

    I don’t think so frank, look here: That option was not enabled. This is my default options.

    View post on imgur.com

    View post on imgur.com

    View post on imgur.com

    View post on imgur.com

    • This reply was modified 7 years, 8 months ago by Amir.
Viewing 15 replies - 1 through 15 (of 66 total)
  • The topic ‘“liveblog”; known 2.2 issues’ is closed to new replies.