Why ribbon in addititonal link-tag?

  • I really like the plugin so far ??

    But why does the ribbon need to be in it’s own link-tag?
    I guess this is what makes the ribbon flicker when hovering over the product image (with link) and the ribbon link.

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author starblank

    (@starblank)

    Hi,

    Thanks for your comment (and for your support to other bugs), i have not seen any flickering so far, but i’ll check it

    Regards

    Thread Starter rehvision

    (@rehvision)

    Okay I found the problem and got it fixed!
    I lower the opacity of products in lists on a:hover and since the ribbon is also an <a> tag, the same rule applied there and caused the flickering when hovering between the two links.

    Now I simply changed to a:not(:first-child):hover, since the ribbon comes first and the problem is solved.

    And now it also makes sense to me, why the ribbon has a link: because otherwise the product wouldn’t be clickable in the area of the ribbon.

    Plugin Author starblank

    (@starblank)

    You’re right, and i have to find a more elegant solution for this… maybe i should draw the ribbon with canvas, avoiding the ‘rectangle’ containing the ribbon.

    I’ll check it for next release

    Thread Starter rehvision

    (@rehvision)

    Doing it with canvas sounds good, probably simpler with the correct positioning since the small :before and :after caps are not that size independent (I changed the font-settings and -size a little to test).

    But anyways, thanks @starblank

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Why ribbon in addititonal link-tag?’ is closed to new replies.