Pull Request for more generic usage

  • Hey,

    This script promises to be just what I’m after, and was about to attempt to build – but I’d like it to be more generic (i.e. to work with more than just Google Analytics).

    I’m happy to contribute pull requests – but before doing so figured it would be worth asking if you’re still active in development for it and open to merging them in.

    I’ll push my changes to this GitHub repo:
    https://github.com/Patabugen/cache-external-scripts

    I’ve only done some refactoring for now, but should get around to adding some features this week.

    The page I need help with: [log in to see the link]

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Voorsie

    (@voorsie)

    Hi there,

    cool, very appreciated.

    I have been thinking already on how to approach and extend this plugin.
    I will contact you by mail to share my thoughts!

    i.e. to work with more than just Google Analytics

    Yes, please! It is a pain to not achieve the maximum score in gtmetrix because “Leverage browser caching” appears in red for external files.

    Let us know if we can help. Thank you!!

    I wonder if there’s any new development regarding the more generic usage of this plugin?

    @patabugen and @voorsie do you have anything to report? ??

    Thread Starter Patabugen

    (@patabugen)

    Hey Sinip,

    I’m afraid I’m no longer working towards a more generic usage. I ran into lots of complications which made it much harder than it first appeared – and the client I needed the plugin for was happy with their site’s speed without it so I had to prioritise other things.

    In case you, or someone else, wants to take it up the kind of complications were scripts which included query strings, or language identifiers (facebook does this, I think) in the middle of the scripts. That meant you suddenly needed to use regexes to find and reconstruct scripts rather than just matching on the name (as this plugin currently does).

    I spoke with Voorsie a bit by email and I’m sure they wouldn’t mind me privatly sharing the conversation with you if you wanted to see our thoughts/comments.

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Pull Request for more generic usage’ is closed to new replies.

Tags