Use of short open tag

  • Resolved frietsje

    (@frietsje)


    6 years, 10 months ago

    Please don’t use the short PHP open tag <? in fancybox-3-for-wordpress.php line 192. On servers where short tags are disabled (default setting) the plugin won’t install.

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author w3dev

    (@w3dev)

    Thanks for catching that, I am pushing a fix now and also updated the core fancyBox script.

    Thread Starter frietsje

    (@frietsje)

    Thanks for your quick reply and update!

    If I may give another remark, the fancybox js file is loaded in the footer (which is great :)). The custom js script for adding the classes and starting the fancybox is loaded in the head, which caused issues because we load jquery in the footer as well.

    We added jquery in the head now as a workaround, but maybe there are other options? (load the script with the wp_footer hook?)

    Cheers,
    Frank

    Plugin Author w3dev

    (@w3dev)

    You’re right on this, it should be in the footer. I’m pushing an update through today that will move it down where it belongs! Thanks again.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Use of short open tag’ is closed to new replies.