File: /lib/Advman/Dal.php
Line: 43 (approx)
These lines if never propagated with a value, default to an empty value, that always forces a save of an empty value, which will be updated next time with another empty value.
Essentially adding unnecessary load or in my case 0.5 seconds, which could be avoided.
# This code always wants to save
// Get networks data
$d = get_option('plugin_advman_networks');
if (empty($d)) {
$d = array();
$save = true;
}
$data['networks'] = $d;# Save functions (update_option) are expensive in terms of load, causing the 0.5s lag
if ($save) {
update_option('plugin_advman_settings', $data['settings']);
update_option('plugin_advman_ads', $data['ads']);
update_option('plugin_advman_networks', $data['networks']);
update_option('plugin_advman_stats', $data['stats']);
}# In my case I made it ignore empty arrays. I also moved the update_options in to the actually save trigger, as it was calling update_option 4 times when just the stats were updated, thus 3 times not needed.
// Get networks data
$d = get_option('plugin_advman_networks');
if (empty($d) && !is_array($d)) {
$d = array();
update_option('plugin_advman_networks', $d);
}
$data['networks'] = $d;Hope that helps, let me know if I can help more.
]]>We have a few questions about this plugin.
We want to know if the following can be done: Client sells different ads on a website and there are different placements that will cost differently. Each Ad will have different rotations for different advertisers. The ad will need to change after a predetermined about of time while there is a user on page. Is that possible?
Is there ecommerce built in (to sell the ads)?
Is there any site that is utilizing this plug that you can share with us so that we can see it in action?
Thank you.
]]>Hi
How can I create a custom Ad Type. I only see the type “HTML” and can’t change it. I would like to create different ad types with different max ads per page policies. For example one ad type for google link ads and another of classic google ads, etc..
thanks for your help.
J.
]]>Saw this error popping up again (under nginx 1.10.0 with fpm_php 7.0):
2016/05/30 15:23:54 [error] 23869#23869: *46246 FastCGI sent in stderr: "PHP message: PHP Fatal error: Uncaught Error: Call to a member function get_network_property_defaults() on null in [... my path...]/wp-content/plugins/advertising-manager/lib/Advman/Template/Ad/Edit.php:10
Stack trace:
#0 [... my path...]/wp-content/plugins/advertising-manager/lib/Advman/Admin.php(430): Advman_Template_Ad_Edit->display(NULL)
#1 [... my path...]/wp-includes/plugin.php(525): Advman_Admin::edit_ad('')
#2 [... my path...]/wp-admin/admin.php(236): do_action('admin_page_advm...')
#3 {main}
thrown in [... my path...]/wp-content/plugins/advertising-manager/lib/Advman/Template/Ad/Edit.php on line 10" while reading response header from upstream, client: [... my IP address...], server: [...my server name...], request: "POST /wp-admin/admin.php?page=advman-ad&ad=9 HTTP/1.1", upstream: "fastcgi://127.0.0.1:9013", host: "[...my server name...]", referrer: "https://[...my server name...]/wp-admin/admin.php?page=advman-ad&ad=9"This was already fixed a year ago (see https://www.ads-software.com/support/topic/fatal-error-call-to-undefined-method-stdclassget_network_property_defaults for previous discussion) but it seems to be popping up again under PHP 7. Strangely, though, it doesn’t seem to affect the overall plugin so much as before (I believe that things did, indeed, get properly saved).
]]>Call to undefined function split() in [...mypath...]/wp-content/plugins/advertising-manager/lib/OX/Ad.php
is fixed by opening the file in question, looking for line 78 which says:
list($width, $height) = split('[x]', $value);
split() has been deprecated and removed on PHP 7, so the alternative is something like:
list($width, $height) = str_split('[x]', $value);
This will not work 100%, but at least it will allow the plugin to work until a better fix is made.
Also, the plugin is not totally HTTPS-friendly — a few references are still made to resources using https:// when they should be made using // to be sure they work well under HTTP and HTTPS. For those who wish to run websites with HTTPS, it’s fulcral that everything — and this obviously means all ads! — is transferred via HTTPS, or some browsers will silently ignore those blocks and not load them.
]]>I am not sure how to use ‘weight’. A higher number means greater frequency?
]]>Seeking and easy way to track multiple banner ads but then be able to collect the data and download or e-mail on a yearly basis (the # of clicks) on an annual basis. I am trying to use ColorNews Pro or ColorMag pro from Themegrill.com. Any suggestions would be most welcome. i would think that a magazine and newspaper site would have some serious ad management but if I can’t supply the data to prove the value of the advertisers ads – then that won’t work out for me. Have to be able to prove the value in an easy, quick and e-mailable report (excel, pdf ?) Both of these themes above say you can export to XML but when I try to – it doesn’t really do anything (even after I put some additional clicks on this banner ads. Also and just as important, is that I can pic and choose the time frame that I want the report to cover e.g. month, quarter, year. Since the site is not up – I cannot show you – but the old site is still online and you can see all the banner ads near the bottom of the homepage on https://www.fishrockport.com. Thank you so much!
]]>Hello
Measuring the loading time of my website I see that the 73% is due to this plugin. This means 4,5 seg with is a lot and negatively affects SEO. Is there any way to reduce the loading time of the puglin? Can it be set in assyncronous mode?
Thank you
]]>Hi
I am having some problems when using Analytics:
No data is displayed in the columns views, clicks, and quality, although I can check in Adsense or other programs that the banners are clicked. How can I turn on these measurements?
Analytics seems to be available only for Today and Yesterday, but not for the other options. How can they be activated?
Thank you for your help
]]>As soon as I activated WooCommerce this plugin clashed with it and would not show the ads entry in the backend.
]]>Hey,
Currently using the latest version of Advertising Manager (3.5.3) with the latests WordPress installation (4.2.3) on a client website. I updated them yesterday and since then the TinyMCE editor has been broken (no toolbar in visual editor and not able to enter any text into the visual editor)
I have checked to ensure it is Advertising Manager causing this by disabling all plugins and then enabling them one by one. The editor worked until I re-activated Advertising Manager. I assume this is a conflict with the latest WordPress update?
Is this an issue you are currently aware of, and if so do you have any ETA on a fix?
Thanks,
Ed
Made by Falcon
I can see the analytics of “Today” but “yesterday” shows the todays stats all over again.
When I try to see the “last 7 days” or “Month” the analytics are empty, not even the table that shows the ad.
]]>When advertising manager v3.5.3 is activated all posts are blank. If i deactivate the content comes back
I run ads in widgets in sidebar and also in content of posts with this
<div style=”float: right; padding-left: 10px; padding-bottom: 5px; padding-top: 5px;”>[ad name=”HEA blog 300×250″]</div>
]]>When advertising manager v3.5.3 is activated all posts are blank. If i deactivate the content comes back
I run ads in widgets in sidebar and also in content of posts with this
<div style=”float: right; padding-left: 10px; padding-bottom: 5px; padding-top: 5px;”>[ad name=”HEA blog 300×250″]</div>
]]>Banner ads (using WordPress media) don’t seem to work in Chrome.
Case in point:
As you can see in Firefox there is an ad on top of the right sidebar at https://admissions.sg/interview-with-ie-admissions-director-viet-ha-tran/
But the same page shows no ad in Chrome! ??
]]>Hi,
My MySQL Slow Queries Log is filling up with these:
# Query_time: 3.377560 Lock_time: 0.048966 Rows_sent: 0 Rows_examined: 1
SET timestamp=1434785316;
UPDATE wp_options SET option_value = {5MB of serialised data}
WHERE option_name = 'plugin_advman_stats';One problem is that the query is obviously slow and the second problem is that log file is growing so big I’ve had to turn off slow query logging.
I’m thinking there must be a better way to store this data?
]]>I have 4 ads. 2 are named “advertisername_homepage”, and 2 are named “advertisername_popup”. All 4 have the weight “50.”
The “homepage” ones seem to come up more or less randomly.
The “popup” ones are favoring one ad over the other by a factor of 5 to 1 in a sample of 1400.
I have selected all items in all select boxes under “Website Display Options.”
I feel like I must have overlooked something essential, but I can’t seem to put my finger on it. Even distribution is unfortunately a requirement, since advertisers pay per month, rather than per impression.
]]>How do I specify cycling jpg/png banner ads?
So far all I seem to only find ways to create ad spaces for ads supplied by external services.
]]>We have unchecked the Tags and Categories we want to exclude from displaying ads however the ads are still displaying. Please advise.
]]>I asked this three weeks ago at the end of another thread and never saw an answer.
I just upgraded to the latest Advertising Manager. Here is what I inserted in my latest post: [ad#Google Adsense links 468×15]. It is under the second and third pictures and after the last paragraph in https://sustainingourworld.com/2015/05/07/long-term-and-short-term-benefits-of-solar-energy/ The code is in both the visual and text editors, just not in the post. Am I doing something wrong?
Also, on another thread you suggested another plugin to replace all the old ad codes. I found this one in an old post: [ad name=”Google Adsense 728×90″]. Do I understand correctly that the plugin will go through all my posts and replace the old code with the new one?
]]>My index page shows the 10 first posts. It used to show the ads only in the first 3, which is the Google limit. Now it tries to show ads on all the posts. Advertising manager is no longer working as it should. I didn’t change anything on the config. The ad limit is set to 3 as always was.
]]>The visual editor for posts, pages and other areas in the admin disappears when this plugin is enabled.
]]>Within days, in two of my blogs all ads disappeared. I mean, I had a number of ads created but now if I go to the All Ads tab I see only a “There are currently no ads. Try to create one to get started” message. What can be happened? Is there any way to recover the ads already configured from some file on my servers?
]]>Hi,
Recently I’ve been adding new ads from Google AdSense, and apparently Advertising Manager doesn’t seem to recognize them as such (only the old code is properly recognized).
It’s not very serious, since Advertising Manager still recognizes it as an HTML ad, and, as such, it works. But it would be nice to add some support for the new code for Google AdSense — after all, it’s still one of the more popular sources for ads on the Web ??
Thanks in advance!
Cheers,
– Gwyn
]]>Hi Scott
Since upgrading to Advertising Manager 3.5.1, I’ve had problems with partial page loads for some pages on raglan23.co.nz
At first I thought it was Jetpack so disabled that. Then I thought it was Business Directory as the issue stopped when that was deactivated.
The developer for Business Directory investigated the issue and found that it was a line of code in Advertising Manager that was causing a high demand on server memory. See the full report below.
So basically either Advertising Manger has to be made to run with less memory or the provider has to allow more memory and that often isn’t an option on a shared server.
Regards,
Rodger
Business Directory Report and Advice
This was a memory limit, just as I thought. That it disappeared when either BD or Advertising Manager were disabled just supports that. The same thing would’ve happened if other plugins were disabled.
Instead of commenting out the problematic line like I did before, I now followed the execution of that function to see where it was failing exactly.
After passing through several classes and functions the incrementStats() function above ends up calling update_option inside advertising-manager/lib/Advman/Dal.php (line 92). This is the exact spot where the script execution stopped.
I checked the memory usage before the update_option() call: it was 113 MB and the configured memory limit for PHP is 128 MB. Since update_option()does several things internally, some of which include retrieving the previous value (which in this case is a huge array), it’s completely normal for this function to exceed the limit.
In some severs, you can increase the memory limit via a PHP function (ini_set()). That was the case here so I increased the limit to 256M by adding some code to advertising-manager/advertising-manager.php (line 17):
@ini_set( ‘memory_limit’, ‘256M’ );
That makes everything work with no line commented out, proving the memory limit was the problem all along. That being said, this is hack. If the customer has a way to increase the memory limit via some admin panel or by contacting the hosting provider, that’s what he should do.
After that, he should remove the line above.
I get the following error in the console when viewing a post or page in the admin console
Failed to load: https://fih.dev/wp-content/plugins/advertising-manager/scripts/advman-editor.js"
As a result, the edit function is inaccessible, showing now text, now visual editor, 0 word count and no ability to click the form to make any changes to the content. The content it self seem though to be unharmed.
]]>After installing appeared in Ads – Analytics error message:
Warning: Invalid argument supplied for foreach() in /data/web/virtuals/51126/virtual/www/domains/trickoskockou.cz/wp-content/plugins/advertising-manager/lib/OX/Swifty.php on line 110
What to do?
]]>Hi
I allowed ad quality measurements in my page but I don’t get any information. Neeither I have received the blog domain and admin email address to Ad.js to obtain a client ID.
I am interested in this tool. How can I get this information?
Thanks
]]>My site crtive is having issues with the Advertising Manager.
The visual editor appears white and I have gone through all steps on the forums.
I deactivated all plugins (which brought back the editor) then went through one by one and activated them, as soon as I activated Advertising Manager, the problem appeared again.
Hi Scott:
We’re new to your plugin and have just added it to our website, so far so good! We do have a couple of questions:
1. On the Analytics side of the plugin we’re getting impressions no problem but how do we get clicks tracked? Our advert is an image with a hyperlink to an external website and we’ve clicked on the advert to ensure that the link is working properly and that click hasn’t registered.
2. We made our link rel=”nofollow” just in case but do we need this or does your plugin automatically make all adverts nofollow?
Thanks for your help!
Fiona